Feat[bmq]: bmqa::Message::totalSize - #1247
Merged
Merged
Conversation
dorjesinpo
force-pushed
the
dev/get-properties-size
branch
from
April 1, 2026 23:51
2c712c5 to
74b6be2
Compare
dorjesinpo
changed the title
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
dev/get-properties-size
branch
from
April 9, 2026 17:31
74b6be2 to
2a0f63f
Compare
dorjesinpo
changed the title
pniedzielski
approved these changes
Apr 9, 2026
pniedzielski
left a comment
pniedzielski
left a comment
Collaborator
There was a problem hiding this comment.
Easiest PR to review ever, happy to see the tests too.
Safe to squash-merge
Collaborator
|
I'll let the CI go through before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of adding
bmqa::Message::messagePropertiesAndPaddingSize, addingbmqa::Message::totalSize