Feat: Introduce BMQ_ASSERT_LEVEL cache variable - #1298
Merged
Conversation
pniedzielski
force-pushed
the
fix/bsls_assert
branch
from
April 13, 2026 21:21
690de52 to
59843d3
Compare
pniedzielski
marked this pull request as ready for review
April 13, 2026 21:22
pniedzielski
force-pushed
the
fix/bsls_assert
branch
2 times, most recently
from
April 14, 2026 18:11
54e0205 to
79e359b
Compare
hallfox
reviewed
Apr 14, 2026
Rather than invariably setting the assert level we compile at based on the build mode (release or non-release), this patch introduces a new cache variable `BMQ_ASSERT_LEVEL`, which can override the default assert level computed based on the build mode. For explicitness’s sake, we set this to SAFE in our CMakePresets, but users can now override this. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
fix/bsls_assert
branch
from
April 14, 2026 19:49
79e359b to
5b51378
Compare
hallfox
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than invariably setting the assert level we compile at based on the build mode (release or non-release), this patch introduces a new cache variable
BMQ_ASSERT_LEVEL, which can override the default assert level computed based on the build mode. For explicitness’s sake, we set this to SAFE in our CMakePresets, but users can now override this.Supercedes: #1243