refactor: enhance m_bmqstoragetool_parameters.h - #1583
Open
Mauricio0704 wants to merge 3 commits into
Open
Conversation
Collaborator
|
@dorjesinpo Will this conflict with your storage writer? |
678098
reviewed
Jul 23, 2026
Comment on lines
+30
to
+33
| // MQB | ||
| #include <mqbs_datafileiterator.h> | ||
| #include <mqbs_journalfileiterator.h> | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| // MQB | |
| #include <mqbs_datafileiterator.h> | |
| #include <mqbs_journalfileiterator.h> |
These includes might be replaced with forward declarations because the types are only used as pointers in this header
Comment on lines
+64
to
+66
| #include <mqbs_datafileiterator.h> | ||
| #include <mqbs_filestoreprotocolprinter.h> | ||
| #include <mqbs_journalfileiterator.h> |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include <mqbs_datafileiterator.h> | |
| #include <mqbs_filestoreprotocolprinter.h> | |
| #include <mqbs_journalfileiterator.h> | |
| #include <mqbs_filestoreprotocolprinter.h> |
These 2 includes can also be replaced with forward declarations to reduce the burden of including too much
Author
|
Thanks for the feedback. I've pushed the changes. The MQB iterators are now forward-declared in the headers, and the includes moved to the .cpp files that dereference them. |
Collaborator
|
Hi @Mauricio0704, the UI shows unresolved merge conflicts. Could you rebase your branch to the latest main and solve them? |
- Remove unused includes from the header and add direct includes to printer.h and searchresult.h - Move record-type and print-mode constants into an unnamed namespace in the .cpp as bsl::string_view - Add allocator traits to CommandLineArguments and Parameters - Store d_allocator_p in each class and remove allocator argument used in other functions Signed-off-by: Mauricio0704 <mausancarr0704@gmail.com>
Signed-off-by: Mauricio0704 <mausancarr0704@gmail.com>
Mauricio0704
force-pushed
the
refactor/1507-enhance-parameters-header
branch
from
July 27, 2026 17:07
8cc2f7f to
673b291
Compare
Author
678098
reviewed
Jul 27, 2026
Signed-off-by: Mauricio0704 <mausancarr0704@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1507
@678098 could you take a look when you have a moment? Thanks!