Fix[mqbs::FileStore]: Track write-head leaseId on applied records - #1681
Closed
kaikulimu wants to merge 1 commit into
Closed
Fix[mqbs::FileStore]: Track write-head leaseId on applied records #1681kaikulimu wants to merge 1 commit into
kaikulimu wants to merge 1 commit into
Conversation
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
kaikulimu
force-pushed
the
track-write-head-lease-id
branch
from
August 3, 2026 19:53
3b8cd14 to
0abff77
Compare
kaikulimu
changed the title
kaikulimu
marked this pull request as ready for review
August 3, 2026 20:00
678098
approved these changes
Aug 3, 2026
Collaborator
Author
|
Accidentally closed. Now the changes are on #1687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(leaseId, seqNum)cursor) to the leaseId of every record it applies inprocessStorageEvent, not just during partition-sync. Previously the leaseId was bumped only for partition-sync events, so a record carrying a higher leaseId applied through any other path left the write head — and thereforewriteHeadSeqNum()— lagging the record just written.setActivePrimaryfor the new leaseId reset the (now stale) sequence number to zero, which can cascade into a spurious out-of-sync/abort.setActivePrimary) has been processed. The write head now follows the record so the PSN stays correct regardless of ordering.