Refactor: AlignedPrinter to accept string - #1682
Open
JJC3321 wants to merge 5 commits into
Open
Conversation
Signed-off-by: Jian Jin Chen <jianjinchen59@gmail.com>
JJC3321
changed the title
Signed-off-by: Jian Jin Chen <jianjinchen59@gmail.com>
JJC3321
force-pushed
the
refactor/bmqu-AlignedPrinter
branch
from
August 3, 2026 16:39
ec45ba0 to
8b43bd0
Compare
Signed-off-by: Jian Jin Chen <jianjinchen59@gmail.com>
Author
|
@678098 Can you approve the CI/CD again as I fix the sign-off and formatting issue? |
Author
|
@678098, can I get a review on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #564
Describe your changes
Refactor bmqu::AlignedPrinter and bmqu::JsonPrinter so field names use bsl::string passed by const reference, instead of const char*. Update all call sites that used the old API.
Testing performed
Compiled the affected translation units locally in WSL (bmqu_alignedprinter, bmqu_jsonprinter, mqbs_filestoreprotocolprinter, bmqstoragetool printer/cslprinter, and bmqtool storageinspector). Compilation succeeded.
Additional context
Add any other context about your contribution here.