[clang] Handle LP64 long-element NEON vectors in the Itanium mangler - #318
Open
Cfretz244 wants to merge 1 commit into
Open
[clang] Handle LP64 long-element NEON vectors in the Itanium mangler#318Cfretz244 wants to merge 1 commit into
Cfretz244 wants to merge 1 commit into
Conversation
LP64 targets (Darwin AArch64) predeclare the 64-bit NEON element type as
plain long; mangleNeonVectorType's switches only handled
LongLong/ULongLong and hit llvm_unreachable("unexpected Neon vector
element type") -- reachable whenever an instantiation over the
predeclared global typedefs (__Int64x1_t et al.) is mangled, which
reflection's eager enumeration of translation-unit members makes easy.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314.
LP64 targets (Darwin AArch64) predeclare the 64-bit NEON element type as plain
long;mangleNeonVectorType's switches only handledLongLong/ULongLongand hitllvm_unreachable("unexpected Neon vector element type")— reachable whenever an instantiation over the predeclared global typedefs (__Int64x1_tet al.) is mangled, which reflection's enumeration of translation-unit members makes easy. AddLong/ULongarms (int64_t/uint64_t, andpoly64_tin the polynomial switch).Validation (Apple Silicon, Release+assertions, base
837da39): the repro ICEs at pristine base and compiles clean with this change (verified both directions by reverting just this file);clang/test/Reflectionat parity.