[libc++] Fix symbol_of/u8symbol_of table entry for op_caret_equals - #320
Open
Cfretz244 wants to merge 1 commit into
Open
[libc++] Fix symbol_of/u8symbol_of table entry for op_caret_equals#320Cfretz244 wants to merge 1 commit into
Cfretz244 wants to merge 1 commit into
Conversation
Both operator-symbol tables in <meta> spelled the compound-xor entry (between "%=" and "&=") as "^", duplicating plain xor. Every consumer rendering operator names from reflections got "^" for operator^= -- field shape: generated binding source called self.operator^(...) for absl::int128's operator^=, a non-existent member. Adds a regression test covering the full compound-assignment row of both tables. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319.
Both operator-symbol tables in
<meta>(symbol_ofandu8symbol_of) spelled theop_caret_equalsentry — between"%="and"&="— as"^", duplicating the plain-xor row. Consumers rendering operator names from reflections got"^"foroperator^=; field shape: a binding generator emittedself.operator^(...)forabsl::int128::operator^=, a non-existent member. (Splice-based consumers never notice;operator_ofitself is correct, so only textual renderers see the bug.)Data-only fix in both tables, plus
libcxx/test/std/experimental/reflection/operator-symbol-tables.pass.cppasserting the full compound-assignment row of both tables.Validated: the new test fails at the base commit and passes with the fix; built and exercised against a real-world reflection workload (36-library binding-generation corpus, including the absl::int128 surface that exposed it).