Error on bulk import validation failures

Signed-off-by: mdouglas47 <mdouglas47@bloomberg.net>

Author: morgando

db/db_tunables.h

@@ -111,7 +111,7 @@ REGISTER_TUNABLE("buffers_per_context", NULL, TUNABLE_INTEGER,
                  NULL);
 REGISTER_TUNABLE("bulk_import_validation_werror",
                  "Treat bulk import input validation warnings as errors. "
-                 "(Default: off)", TUNABLE_BOOLEAN,
+                 "(Default: on)", TUNABLE_BOOLEAN,
                  &gbl_bulk_import_validation_werror, 0, NULL, NULL, NULL,
                  NULL);
 /*

tests/bulkimport.test/runit

@@ -321,8 +321,10 @@ function test_bad_inputs_without_werror() {
 		# Given
 		local dst_tbl=foo src_tbl='bad-table'
 		query_dst_db "create table $dst_tbl(i int)"
+		set_dst_tunable "bulk_import_validation_werror off"
 
-		trap "query_dst_db 'drop table $dst_tbl'" EXIT
+		trap "set_dst_tunable 'bulk_import_validation_werror on';
+			query_dst_db 'drop table $dst_tbl'" EXIT
 
 		# When
 		err=$(query_dst_db "replace table $dst_tbl with LOCAL_$SRC_DBNAME.'"$src_tbl"'" 2>&1)
@@ -339,10 +341,8 @@ function test_bad_inputs_with_werror() {
 		# Given
 		local dst_tbl=foo src_tbl='bad-table'
 		query_dst_db "create table $dst_tbl(i int)"
-		set_dst_tunable "bulk_import_validation_werror on"
 
-		trap "set_dst_tunable 'bulk_import_validation_werror off';
-			query_dst_db 'drop table $dst_tbl'" EXIT
+		trap "query_dst_db 'drop table $dst_tbl'" EXIT
 
 		# When
 		err=$(query_dst_db "replace table $dst_tbl with LOCAL_$SRC_DBNAME.'"$src_tbl"'" 2>&1)

tests/tunables.test/t00_all_tunables.expected

@@ -93,7 +93,7 @@
 (name='btpf_wndw_max', description='Maximum number of pages read ahead', type='INTEGER', value='1000', read_only='N')
 (name='btpf_wndw_min', description='Minimum number of pages read ahead', type='INTEGER', value='100', read_only='N')
 (name='buffers_per_context', description='', type='INTEGER', value='255', read_only='Y')
-(name='bulk_import_validation_werror', description='Treat bulk import input validation warnings as errors. (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
+(name='bulk_import_validation_werror', description='Treat bulk import input validation warnings as errors. (Default: on)', type='BOOLEAN', value='ON', read_only='N')
 (name='bulk_sql_mode', description='Enable reading data in bulk when performing a scan (alternative is single-stepping a cursor).', type='BOOLEAN', value='ON', read_only='N')
 (name='bulk_sql_rowlocks', description='', type='BOOLEAN', value='ON', read_only='N')
 (name='bulk_sql_threshold', description='', type='INTEGER', value='2', read_only='N')

util/import_util.c

@@ -3,7 +3,7 @@
 #include <str_util.h>
 #include <logmsg.h>
 
-int gbl_bulk_import_validation_werror = 0;
+int gbl_bulk_import_validation_werror = 1;
 
 enum bulk_import_validation_rc validate_bulk_import_inputs(const char * const dest_tablename, const char * const bulk_import_src_mach,
     const char * const bulk_import_src_dbname, const char * const bulk_import_src_tablename)