Make responses Responsable and return SuccessResponse from QueryBuilder#2
Merged
brunogaspar merged 1 commit intoApr 25, 2026
Merged
Conversation
SuccessResponse and ErrorResponse now implement Laravel's Responsable
interface, so they can be returned directly from controllers without
calling ->respond().
QueryBuilder terminal methods (paginate, cursorPaginate, get) now
return SuccessResponse instead of raw data, inheriting the resource
class from fromResource(). This eliminates the need to repeat the
resource class and call ->respond().
Before:
$products = QueryBuilder::for(Product::class, $request)
->fromResource(ProductResource::class)
->paginate();
return $response->success($products, ProductResource::class)->respond();
After:
return QueryBuilder::for(Product::class, $request)
->fromResource(ProductResource::class)
->paginate();
brunogaspar
force-pushed
the
feature/responsable-and-query-builder-responses
branch
from
e66f58a to
9e33a8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuccessResponse and ErrorResponse now implement Laravel's Responsable interface, so they can be returned directly from controllers without calling ->respond().
QueryBuilder terminal methods (paginate, cursorPaginate, get) now return SuccessResponse instead of raw data, inheriting the resource class from fromResource(). This eliminates the need to repeat the resource class and call ->respond().
Before:
$products = QueryBuilder::for(Product::class, $request)
->fromResource(ProductResource::class)
->paginate();
return $response->success($products, ProductResource::class)->respond();
After:
return QueryBuilder::for(Product::class, $request)
->fromResource(ProductResource::class)
->paginate();