change createMintToInstruction to createMintToCheckedInstruction#369
Open
guagua777 wants to merge 1 commit into
Open
change createMintToInstruction to createMintToCheckedInstruction#369guagua777 wants to merge 1 commit into
guagua777 wants to merge 1 commit into
Conversation
…d harm the experience for new users. Once they become familiar, they will naturally choose which APIs to use. change method createMintToInstruction to createMintToCheckedInstruction
Member
|
@guagua777 we appreciate you taking the time to help improve content_ I agree that mintToChecked adds another layer of safety for beginners, and introducing it in the course is probably better for someone new to the token standard. In addition to the changing the instruction, the Abstracted Instruction part should also be updated to stay consistent; otherwise, it will be confusing to the learners. What do you think? |
dhl
reviewed
Mar 2, 2026
|
|
||
| // Mint tokens to ATA | ||
| const mintToInstruction = createMintToInstruction( | ||
| const mintToInstruction = createMintToCheckedInstruction( |
Member
There was a problem hiding this comment.
We should also update the variable to mintToCheckedInstruction
dhl
requested changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although this method works, it will throw errors during challenges and harm the experience for new users. Once they become familiar, they will naturally choose which APIs to use.
change method createMintToInstruction to createMintToCheckedInstruction