fix(mcp-server): remediate npm audit fast-uri high (#596)#602
Open
bmdhodl wants to merge 1 commit into
Open
Conversation
fast-uri was already patched (3.1.2) on main, so npm audit reports 0 high. This change also clears the 3 remaining hono moderates by adding an overrides entry pinning hono to ^4.12.23 (resolves to 4.12.25), which is past the <4.12.21 advisory range for all four hono GHSAs. npm audit now reports 0 vulnerabilities. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
@bmdhodl this PR has been open 3+ days; review or close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #596
Summary
Resolves the security finding in
mcp-server/tracked by #596. Result:npm auditnow reports 0 vulnerabilities (0 high, 0 moderate).What the audit actually showed
On current
main, the fast-uri HIGH is already cleared — the lockfile resolvesfast-urito3.1.2, which is past the advisory range, so it is no longer flagged. The only remaining findings were 3 moderate hono advisories reached transitively through@modelcontextprotocol/sdk→@hono/node-server→hono(resolved 4.12.18). npm reported these as "No fix available" because it will not auto-bump a transitively-pinned dependency.Fix
Added an
overridesentry pinninghonoto^4.12.23(resolves to4.12.25). All four hono GHSAs (GHSA-xrhx-7g5j-rcj5, GHSA-3hrh-pfw6-9m5x, GHSA-f577-qrjj-4474, GHSA-2gcr-mfcq-wcc3) have a vulnerable range of<4.12.21, so this clears every one. This matches the target of dependabot #570 (hono 4.12.23) but goes through an override since the SDK is the pinning parent — the bump-alone in #570 would not flow through to the SDK's transitive hono. This supersedes dependabot #570.Before
After
Files changed
mcp-server/package.json(addedoverrides)mcp-server/package-lock.json(hono 4.12.18 → 4.12.25)npm run build(tsc) passes. No source changes.