-
Notifications
You must be signed in to change notification settings - Fork 0
ci(release-please): switch to workflow_dispatch-only trigger #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,23 +8,35 @@ name: Release Please | |
| # | ||
| # The release PR therefore goes through normal CI before merge, so a broken | ||
| # tree never gets tagged. | ||
| # | ||
| # Manual-trigger only: previously this fired on every push to `dev`, which | ||
| # meant a release PR sat open after every `feat:`/`fix:`/`perf:` merge. | ||
| # Maintainer now invokes it via the Actions UI ("Run workflow") when ready | ||
| # to cut a release. release-please walks `dev` since the last tag and opens | ||
| # the release PR on that single dispatch. | ||
|
|
||
| on: | ||
| push: | ||
| branches: [dev] | ||
| workflow_dispatch: | ||
|
|
||
|
Comment on lines
18
to
20
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch — fixed in 9747584. Pinned the concurrency group to |
||
| permissions: | ||
| contents: write | ||
|
|
||
| concurrency: | ||
| # Serialize so two pushes can't open conflicting release PRs. | ||
| group: release-please-${{ github.ref }} | ||
| # release-please always operates on `dev` (target-branch is hardcoded | ||
| # below), regardless of which ref the dispatch fires from. Pin the group | ||
| # to that target so two simultaneous dispatches from different refs still | ||
| # serialize — keying on github.ref would let them race and produce | ||
| # conflicting release PRs. | ||
| group: release-please-dev | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| release-please: | ||
| runs-on: ubuntu-24.04 | ||
| # Belt-and-suspenders: target-branch is hardcoded to `dev` below, so | ||
| # dispatching from any other ref would just run a (possibly stale) copy | ||
| # of this workflow against `dev`'s history. Refuse outright instead. | ||
| if: github.ref_name == 'dev' | ||
| # Scoped here (rather than workflow-level) so future jobs don't | ||
| # silently inherit PR write access. | ||
| permissions: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
custom-instructions/repo/.github/copilot-instructions.mddoes not exist in this repo (git ls-files custom-instructionsreturns nothing) — same hallucinated path that came up on PR #98. The only copilot-instructions file is.github/copilot-instructions.mdand it's already updated in this PR.