Skip to content

Revert modernization#831

Merged
saki7 merged 20 commits intoboostorg:developfrom
saki7:revert-modernization
Sep 13, 2025
Merged

Revert modernization#831
saki7 merged 20 commits intoboostorg:developfrom
saki7:revert-modernization

Conversation

@saki7
Copy link
Copy Markdown
Collaborator

@saki7 saki7 commented Sep 13, 2025 •
edited
Loading

As per recent discussion on the Boost developers' mailing list, we have officially decided to continue development on Spirit.X4.

This PR reverts all the C++23 modernization PRs, and adds the warning and the background information on README.

ref:

saki7 added 20 commits September 13, 2025 08:56
@saki7
Revert "Modernize x3::with (#829)"
49753e2 
This reverts commit e1973fc.
@saki7
Revert "Merge pull request #827 from saki7/modernize-skip"
ac6ed01 
This reverts commit 4cd604a, reversing
changes made to 70f968e.
@saki7
Revert "Merge pull request #820 from saki7/modernize-expect"
385a9c3 
This reverts commit 70f968e, reversing
changes made to b6acdc5.
@saki7
Revert "Merge pull request #817 from saki7/modernize-char-string"
14dfeaf 
This reverts commit b6acdc5, reversing
changes made to 1ef37da.
@saki7
Revert "Merge pull request #826 from saki7/modernize-repeat"
6218dcc 
This reverts commit 1ef37da, reversing
changes made to b1111dc.
@saki7
Revert "Merge pull request #825 from saki7/modernize-raw"
069d2a0 
This reverts commit b1111dc, reversing
changes made to a80d412.
@saki7
Revert "Merge pull request #824 from saki7/modernize-omit"
5d52405 
This reverts commit a80d412, reversing
changes made to 495f936.
@saki7
Revert "Merge pull request #822 from saki7/modernize-matches"
26d6ec1 
This reverts commit 495f936, reversing
changes made to b86852d.
@saki7
Revert "Merge pull request #821 from saki7/modernize-lexeme"
bc3138d 
This reverts commit b86852d, reversing
changes made to b389b1c.
@saki7
Revert "Modernize x3::confix (#819)"
c41c9ae 
This reverts commit b389b1c.
@saki7
Revert "Modernize x3::action (#815)"
569c522 
This reverts commit 3df9ca3.
@saki7
Revert "Merge pull request #813 from saki7/modernize-rule-parser"
e4d3fce 
This reverts commit bae393d, reversing
changes made to c64a914.
@saki7
Revert "Use concepts for attribute category overload resolution (#812)"
63fabec 
This reverts commit c64a914.
@saki7
Revert "Fix typo in README"
96b81d3 
This reverts commit 52c7e04.
@saki7
Revert "Harmless commit to make sure CI is working on direct push"
795d616 
This reverts commit 3ed39f1.
@saki7
Revert "Skip the "build" job for empty changes case"
a0c9105 
This reverts commit af360dc.
@saki7
Revert "Add CI badge"
421707f 
This reverts commit 65208fb.
@saki7
Revert "Merge pull request #808 from saki7/refine-ci-cpp23"
ec681a2 
This reverts commit f66350f, reversing
changes made to d21af8b.
@saki7
Revert "Define the concept of "parser" in X3 (#807)"
d88f114 
This reverts commit d21af8b.
@saki7
Add information about Spirit.X4
6772cdd
@saki7 saki7 self-assigned this Sep 13, 2025
@saki7
Copy link
Copy Markdown
Collaborator Author

saki7 commented Sep 13, 2025

I'm merging this right away. The CI on AppVeyor was poorly configured even before the modernization and it takes half a day to finish. This revert contains only the "git revert" and the README changes, so it is trivial that I successfully reverted everything, given the fact that GHA jobs are passing.

@saki7 saki7 merged commit 9801755 into boostorg:develop Sep 13, 2025
12 of 13 checks passed
@saki7 saki7 deleted the revert-modernization branch September 13, 2025 01:23
@saki7
Copy link
Copy Markdown
Collaborator Author

saki7 commented Sep 13, 2025

Note: the CI is failing on develop, but it was already failing since May. I forgot to mention this fact.

I technically reverted everything. The failure on AppVeyor should be considered spurious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@saki7 saki7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saki7