Skip to content

cfs: Restore download progress for update and switch#2322

Queued
cgwalters wants to merge 1 commit into
bootc-dev:mainfrom
cgwalters:cfs-progress
Queued

cfs: Restore download progress for update and switch#2322
cgwalters wants to merge 1 commit into
bootc-dev:mainfrom
cgwalters:cfs-progress

Conversation

@cgwalters

@cgwalters cgwalters commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Closes: #2316

composefs switched to having a progress API instead of writing progress directly to the tty itself; we need to wire it up now to our progress infrastructure.

Assisted-by: AI

@cgwalters
cfs: Restore download progress for update and switch
43f406c 
Closes: bootc-dev#2316

composefs switched to having a progress API instead of writing
progress directly to the tty itself; we need to wire it up
now to our progress infrastructure.

Assisted-by: AI
Signed-off-by: Colin Walters <walters@verbum.org>
@bootc-bot
bootc-bot Bot requested a review from gursewak1997 July 16, 2026 18:11
@cgwalters cgwalters added the ci/tier-1 Run CI for tier-1 OS (centos-10) only label Jul 16, 2026
jmarrero
jmarrero approved these changes Jul 16, 2026
View reviewed changes

@jmarrero jmarrero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero
jmarrero enabled auto-merge July 16, 2026 18:50
@renner0e

renner0e commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I tested this PR on a fedora kinoite based image and the progress bar only returned when not using unified storage

@cgwalters

cgwalters commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

I tested this PR on a fedora kinoite based image and the progress bar only returned when not using unified storage

I don't believe we had a real progress bar at all for unified storage (podman pull) before - that one wasn't a regression, but something to fix separately.

@jmarrero
jmarrero added this pull request to the merge queue Jul 16, 2026
@renner0e

renner0e commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

I tested this PR on a fedora kinoite based image and the progress bar only returned when not using unified storage

I don't believe we had a real progress bar at all for unified storage (podman pull) before - that one wasn't a regression, but something to fix separately.

Alright, thanks for the clarification.

@cgwalters

cgwalters commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

(It requires podman 6.0 with podman-container-tools/podman#28224 - and see related comments )

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2026
@cgwalters
cgwalters added this pull request to the merge queue Jul 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2026
@cgwalters
cgwalters added this pull request to the merge queue Jul 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2026
@cgwalters
cgwalters added this pull request to the merge queue Jul 17, 2026
@cgwalters

cgwalters commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator Author

Man, the flakes 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmarrero jmarrero jmarrero approved these changes
@gursewak1997 gursewak1997 Awaiting requested review from gursewak1997

Assignees

No one assigned

Labels

ci/tier-1 Run CI for tier-1 OS (centos-10) only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Composefs Backend] As of version 1.16, download progress for chunks is no longer shown by "bootc update" and "bootc switch"

3 participants

@cgwalters @renner0e @jmarrero