Add sky map visualization and optical parameter tracking#143
Open
tomaszmrugalski wants to merge 3 commits into
Open
Add sky map visualization and optical parameter tracking#143tomaszmrugalski wants to merge 3 commits into
tomaszmrugalski wants to merge 3 commits into
Conversation
…form - SkyViewComponent: Aladin Lite overlay for a single project FOV (polygon on DSS imagery) - SkyMapComponent: full-sky AIT map of all active projects at /sky-map, per-scope color coding, toggleable scope filter chips - project-detail: embed sky view card when project has optical params - project-form-dialog: auto-fill focal/resx/resy/pixel_x/pixel_y from telescope sensor on scope selection; fields are editable; live FOV chip (w×h degrees) - app-routing: add /sky-map route - layout menu: add Sky Map link - models/project: add optical param fields to Project, ProjectCreate, ProjectUpdate Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mn5wvy2To8d95XVLTBcRXE
…optical params - sky-view.component.spec.ts: 5 unit tests for computeFovDeg (correctness, monotonicity, symmetry) - sky-map.component.spec.ts: 7 tests for SkyMapComponent (loading, scope toggle, error state) - project-form-dialog.component.spec.ts: add TelescopeService mock, update existing save test to include new null optical param fields, add 3 tests for fovChip and explicit param payload - sky-view.component.ts: use inject() instead of constructor injection (lint fix) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mn5wvy2To8d95XVLTBcRXE
Required to pass the Angular ESLint prefer-control-flow rule. The template was already updated in the lint-fix commit but the working tree still had the old version unstaged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mn5wvy2To8d95XVLTBcRXE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new sky map component for visualizing all projects across the sky, and introduces optical parameter tracking (focal length, sensor dimensions, pixel pitch) to projects. These parameters enable precise field-of-view calculations and visualization overlays in both the new sky map and project detail views.
Key Changes
focal,resx,resy,pixel_x,pixel_y, androtationfieldscomputeFovDeg()utility function to derive field-of-view dimensions from sensor geometry (pixels, pixel pitch, focal length)/sky-maproutealadin-lite@^3.9.0-betafor sky visualizationImplementation Details
https://claude.ai/code/session_01Mn5wvy2To8d95XVLTBcRXE