Prepare to support UKIs #1007
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| From 7a35885f3294c0cde362edcb5021556b8906be80 Mon Sep 17 00:00:00 2001 | ||
| From: Arnaldo Garcia Rincon <agarrcia@amazon.com> | ||
| Date: Tue, 4 Aug 2026 03:50:03 +0000 | ||
| Subject: [PATCH] build: correct sd-boot EFI arch on the Bottlerocket SDK | ||
|
|
||
| The SDK cross sysroot mis-reports host_machine.cpu_family(), so systemd's | ||
| efi_arch lookup resolves to the wrong EFI target: 'ia32' on x86_64 and 'arm' on | ||
| aarch64. Correct both from host_machine.cpu(), and drop the IA-32 mixed-mode | ||
| alternate build, which cannot link in this sysroot. | ||
|
|
||
| --- | ||
| meson.build | 38 ++++++++++++++++++++++++++++++-------- | ||
| src/boot/meson.build | 4 ++-- | ||
| 2 files changed, 32 insertions(+), 10 deletions(-) | ||
|
|
||
| diff --git a/meson.build b/meson.build | ||
| index b9d8d52..b5e995f 100644 | ||
| --- a/meson.build | ||
| +++ b/meson.build | ||
| @@ -1942,6 +1942,36 @@ efi_arch = { | ||
| 'x86' : 'ia32', | ||
| }.get(host_machine.cpu_family(), '') | ||
|
|
||
| +# Bottlerocket SDK fix: the cross sysroot reports cpu_family 'x86' even for | ||
| +# x86_64 targets, which makes efi_arch resolve to 'ia32'. Force x64 when the | ||
| +# real target cpu is x86_64. | ||
| +if efi_arch == 'ia32' and host_machine.cpu() == 'x86_64' | ||
| + efi_arch = 'x64' | ||
| +endif | ||
| + | ||
| +# The same SDK quirk applies on 64-bit ARM: cpu_family is reported as 'arm', | ||
| +# so efi_arch resolves to the 32-bit 'arm' EFI target and sd-boot is emitted as | ||
| +# systemd-bootarm.efi with EFI_MACHINE_TYPE_NAME=arm. Force aa64 when the real | ||
| +# target cpu is aarch64, so the binary is named and typed per the EFI spec and | ||
| +# matches the bootaa64.efi/grubaa64.efi convention used by shim and GRUB. | ||
| +# Note: efi_cpu_family is deliberately left resolving to 'arm' below, since the | ||
| +# 'arm' and 'aarch64' entries of efi_arch_c_args are identical | ||
| +# (-mgeneral-regs-only) and the extra 'arm' link arg | ||
| +# (-Wl,--no-wchar-size-warning) is harmless here. | ||
| +if efi_arch == 'arm' and host_machine.cpu() == 'aarch64' | ||
| + efi_arch = 'aa64' | ||
| +endif | ||
| + | ||
| +# Single corrected arch key for all EFI flag lookups, so no flag site can | ||
| +# silently regress to the -m32 (ia32) path on this SDK. | ||
| +if efi_arch == 'x64' | ||
| + efi_cpu_family = 'x86_64' | ||
| +elif efi_arch == 'ia32' | ||
| + efi_cpu_family = 'x86' | ||
| +else | ||
| + efi_cpu_family = host_machine.cpu_family() | ||
| +endif | ||
|
Comment on lines
+24
to
+52
Contributor
There was a problem hiding this comment. [P2] Overriding The patch works around a Bottlerocket-SDK quirk where
Fix.
Contributor
Author
There was a problem hiding this comment. The SDK fix, we can do in a subsequent release. The patch must stay so I'll fix the suggestion. |
||
| + | ||
| pyelftools = pymod.find_installation('python3', | ||
| required : get_option('bootloader'), | ||
| modules : ['elftools']) | ||
| @@ -1954,14 +1984,8 @@ conf.set_quoted('EFI_MACHINE_TYPE_NAME', have ? efi_arch : '') | ||
|
|
||
| efi_arch_alt = '' | ||
| efi_cpu_family_alt = '' | ||
| -if have and efi_arch == 'x64' and cc.links(''' | ||
| - #include <limits.h> | ||
| - int main(int argc, char *argv[]) { | ||
| - return __builtin_popcount(argc - CHAR_MAX); | ||
| - }''', args : ['-m32', '-march=i686'], name : '32bit build possible') | ||
| - efi_arch_alt = 'ia32' | ||
| - efi_cpu_family_alt = 'x86' | ||
| -endif | ||
| +# IA-32 mixed-mode alternate build disabled for Bottlerocket: the SDK cross | ||
| +# sysroot lacks 32-bit glibc headers (gnu/stubs-32.h), so -m32 cannot build. | ||
|
|
||
| pefile = pymod.find_installation('python3', required: false, modules : ['pefile']) | ||
|
|
||
| diff --git a/src/boot/meson.build b/src/boot/meson.build | ||
| index 6327717..28089ef 100644 | ||
| --- a/src/boot/meson.build | ||
| +++ b/src/boot/meson.build | ||
| @@ -313,11 +313,11 @@ efi_archspecs = [ | ||
| 'c_args' : [ | ||
| efi_c_args, | ||
| '-DEFI_MACHINE_TYPE_NAME="' + efi_arch + '"', | ||
| - efi_arch_c_args.get(host_machine.cpu_family(), []), | ||
| + efi_arch_c_args.get(efi_cpu_family, []), | ||
| ], | ||
| 'link_args' : [ | ||
| efi_c_ld_args, | ||
| - efi_arch_c_ld_args.get(host_machine.cpu_family(), []), | ||
| + efi_arch_c_ld_args.get(efi_cpu_family, []), | ||
| ], | ||
| }, | ||
| ] | ||
| -- | ||
| 2.52.0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,186 @@ | ||
| From dd7dfa7106df8f7a0a78d14b3ff494b07eb24025 Mon Sep 17 00:00:00 2001 | ||
| From: Arnaldo Garcia Rincon <agarrcia@amazon.com> | ||
| Date: Wed, 12 Aug 2026 18:55:46 +0000 | ||
| Subject: [PATCH] boot: remove SMBIOS Type 11 kernel-cmdline-extra mechanism | ||
|
|
||
| Remove the ability for sd-boot and the UKI stub to extend the kernel | ||
| command line with values read from SMBIOS Type 11 OEM strings | ||
| ("io.systemd.boot.kernel-cmdline-extra" and | ||
| "io.systemd.stub.kernel-cmdline-extra"). | ||
|
|
||
| SMBIOS Type 11 OEM strings are supplied by the firmware or VMM and | ||
| were being trusted to inject additional kernel command line | ||
| arguments outside of the UKI/boot entry itself. Remove this | ||
| mechanism entirely: | ||
|
|
||
| - src/boot/stub.c: drop cmdline_append_and_measure_smbios() and its | ||
| call site in run(). | ||
| - src/boot/boot.c: drop the block in image_start() that appended the | ||
| "io.systemd.boot.kernel-cmdline-extra" OEM string to the boot | ||
| entry options. | ||
| - src/boot/smbios.c, src/boot/smbios.h: drop | ||
| smbios_find_oem_string(), which no longer has any callers. | ||
|
|
||
| systemd-vmspawn's arg_kernel_cmdline_extra is left untouched: aside | ||
| from the (now dead) SMBIOS Type 11 OEM string arguments it still | ||
| generates for QEMU when booting via a bootloader/UKI, it is also | ||
| used to build the kernel command line passed directly via QEMU's | ||
| -append when booting a kernel image directly, so it is not solely | ||
| tied to this mechanism. | ||
|
|
||
| Documentation under man/ and docs/, and NEWS, are intentionally left | ||
| unchanged. | ||
| --- | ||
| src/boot/boot.c | 12 ------------ | ||
| src/boot/smbios.c | 27 --------------------------- | ||
| src/boot/smbios.h | 2 -- | ||
| src/boot/stub.c | 36 +----------------------------------- | ||
| 4 files changed, 1 insertion(+), 76 deletions(-) | ||
|
|
||
| diff --git a/src/boot/boot.c b/src/boot/boot.c | ||
| index 21aa00b356..da5e97771e 100644 | ||
| --- a/src/boot/boot.c | ||
| +++ b/src/boot/boot.c | ||
| @@ -23,7 +23,6 @@ | ||
| #include "sbat.h" | ||
| #include "secure-boot.h" | ||
| #include "shim.h" | ||
| -#include "smbios.h" | ||
| #include "ticks.h" | ||
| #include "tpm2-pcr.h" | ||
| #include "uki.h" | ||
| @@ -2599,17 +2598,6 @@ static EFI_STATUS image_start( | ||
| * so). */ | ||
| _cleanup_free_ char16_t *options = xstrdup16(options_initrd ?: entry->options_implied ? NULL : entry->options); | ||
|
|
||
| - if (entry->type == LOADER_LINUX && !is_confidential_vm()) { | ||
| - const char *extra = smbios_find_oem_string("io.systemd.boot.kernel-cmdline-extra"); | ||
| - if (extra) { | ||
| - _cleanup_free_ char16_t *tmp = TAKE_PTR(options), *extra16 = xstr8_to_16(extra); | ||
| - if (isempty(tmp)) | ||
| - options = TAKE_PTR(extra16); | ||
| - else | ||
| - options = xasprintf("%ls %ls", tmp, extra16); | ||
| - } | ||
| - } | ||
| - | ||
| /* Prefix profile if it's non-zero */ | ||
| if (entry->profile > 0) { | ||
| _cleanup_free_ char16_t *tmp = TAKE_PTR(options); | ||
| diff --git a/src/boot/smbios.c b/src/boot/smbios.c | ||
| index 329619f85b..844b558cea 100644 | ||
| --- a/src/boot/smbios.c | ||
| +++ b/src/boot/smbios.c | ||
| @@ -182,33 +182,6 @@ bool smbios_in_hypervisor(void) { | ||
| return FLAGS_SET(type0->bios_characteristics_ext[1], 1 << 4); | ||
| } | ||
|
|
||
| -const char* smbios_find_oem_string(const char *name) { | ||
| - uint64_t left; | ||
| - | ||
| - assert(name); | ||
| - | ||
| - const SmbiosTableType11 *type11 = (const SmbiosTableType11 *) get_smbios_table(11, sizeof(SmbiosTableType11), &left); | ||
| - if (!type11) | ||
| - return NULL; | ||
| - | ||
| - assert(left >= type11->header.length); /* get_smbios_table() already validated this */ | ||
| - left -= type11->header.length; | ||
| - | ||
| - for (const char *p = type11->contents, *limit = type11->contents + left; p < limit; ) { | ||
| - const char *e = memchr(p, 0, limit - p); | ||
| - if (!e || e == p) /* Double NUL byte means we've reached the end of the OEM strings. */ | ||
| - break; | ||
| - | ||
| - const char *eq = startswith8(p, name); | ||
| - if (eq && *eq == '=') | ||
| - return eq + 1; | ||
| - | ||
| - p = e + 1; | ||
| - } | ||
| - | ||
| - return NULL; | ||
| -} | ||
| - | ||
| static const char* smbios_get_string(const SmbiosHeader *header, size_t nr, uint64_t left) { | ||
| const char *s = (const char *) ASSERT_PTR(header); | ||
|
|
||
| diff --git a/src/boot/smbios.h b/src/boot/smbios.h | ||
| index 34625c8572..674d702841 100644 | ||
| --- a/src/boot/smbios.h | ||
| +++ b/src/boot/smbios.h | ||
| @@ -5,8 +5,6 @@ | ||
|
|
||
| bool smbios_in_hypervisor(void); | ||
|
|
||
| -const char* smbios_find_oem_string(const char *name); | ||
| - | ||
| typedef struct RawSmbiosInfo { | ||
| const char *manufacturer; | ||
| const char *product_name; | ||
| diff --git a/src/boot/stub.c b/src/boot/stub.c | ||
| index 06bf513950..6904d21fd8 100644 | ||
| --- a/src/boot/stub.c | ||
| +++ b/src/boot/stub.c | ||
| @@ -17,7 +17,6 @@ | ||
| #include "sbat.h" | ||
| #include "secure-boot.h" | ||
| #include "shim.h" | ||
| -#include "smbios.h" | ||
| #include "splash.h" | ||
| #include "tpm2-pcr.h" | ||
| #include "uki.h" | ||
| @@ -768,37 +767,6 @@ static void measure_sections( | ||
| } | ||
| } | ||
|
|
||
| -static void cmdline_append_and_measure_smbios(char16_t **cmdline, int *parameters_measured) { | ||
| - assert(cmdline); | ||
| - assert(parameters_measured); | ||
| - | ||
| - /* SMBIOS OEM Strings data is controlled by the host admin and not covered by the VM attestation, so | ||
| - * MUST NOT be trusted when in a confidential VM */ | ||
| - if (is_confidential_vm()) | ||
| - return; | ||
| - | ||
| - const char *extra = smbios_find_oem_string("io.systemd.stub.kernel-cmdline-extra"); | ||
| - if (!extra) | ||
| - return; | ||
| - | ||
| - _cleanup_free_ char16_t *extra16 = mangle_stub_cmdline(xstr8_to_16(extra)); | ||
| - if (isempty(extra16)) | ||
| - return; | ||
| - | ||
| - /* SMBIOS strings are measured in PCR1, but we also want to measure them in our specific PCR12, as | ||
| - * firmware-owned PCRs are very difficult to use as they'll contain unpredictable measurements that | ||
| - * are not under control of the machine owner. */ | ||
| - bool m = false; | ||
| - (void) tpm_log_load_options(extra16, &m); | ||
| - combine_measured_flag(parameters_measured, m); | ||
| - | ||
| - _cleanup_free_ char16_t *tmp = TAKE_PTR(*cmdline); | ||
| - if (isempty(tmp)) | ||
| - *cmdline = TAKE_PTR(extra16); | ||
| - else | ||
| - *cmdline = xasprintf("%ls %ls", tmp, extra16); | ||
| -} | ||
| - | ||
| static void initrds_free(struct iovec (*initrds)[_INITRD_MAX]) { | ||
| assert(initrds); | ||
|
|
||
| @@ -1219,11 +1187,9 @@ static EFI_STATUS run(EFI_HANDLE image) { | ||
| load_all_addons(image, loaded_image, uname, &cmdline_addons, &dt_addons, &n_dt_addons, &initrd_addons, &n_initrd_addons, &ucode_addons, &n_ucode_addons); | ||
|
|
||
| /* If we have any extra command line to add via PE addons, load them now and append, and measure the | ||
| - * additions together, after the embedded options, but before the smbios ones, so that the order is | ||
| - * reversed from "most hardcoded" to "most dynamic". The global addons are loaded first, and the | ||
| + * additions together, after the embedded options. The global addons are loaded first, and the | ||
| * image-specific ones later, for the same reason. */ | ||
| cmdline_append_and_measure_addons(cmdline_addons, &cmdline, ¶meters_measured); | ||
| - cmdline_append_and_measure_smbios(&cmdline, ¶meters_measured); | ||
|
|
||
| export_common_variables(loaded_image); | ||
| export_stub_variables(loaded_image, profile); | ||
| -- | ||
| 2.52.0 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| From 4c7f0c03faf27097037cdbd3f22d7d17b702c90d Mon Sep 17 00:00:00 2001 | ||
| From: Arnaldo Garcia Rincon <agarrcia@amazon.com> | ||
| Date: Wed, 12 Aug 2026 19:01:30 +0000 | ||
| Subject: [PATCH] boot,vmspawn: finish removing SMBIOS cmdline-extra bits | ||
|
|
||
| Follow-up to the removal of the SMBIOS Type 11 OEM string mechanism | ||
| for kernel command line injection: two leftover references to the | ||
| removed feature remained and are cleaned up here. | ||
|
|
||
| - src/boot/stub.c: stop advertising EFI_STUB_FEATURE_CMDLINE_SMBIOS | ||
| in the StubFeatures EFI variable. The stub no longer reads the | ||
| SMBIOS Type 11 OEM string, so it must not claim to support it. | ||
|
|
||
| - src/vmspawn/vmspawn.c: when booting a guest via a boot loader or | ||
| UKI (i.e. not a direct kernel boot), stop emitting the two | ||
| "-smbios type=11,value=io.systemd.{stub,boot}.kernel-cmdline-extra=..." | ||
| QEMU arguments. Since sd-boot and the UKI stub no longer read these | ||
| OEM strings, that code silently produced inert QEMU arguments and | ||
| gave no indication that the extra kernel command line was dropped. | ||
| A log_warning() is now emitted in that case instead. Direct kernel | ||
| boots are unaffected: they still pass the extra command line via | ||
| QEMU's -append, which does not rely on SMBIOS at all. | ||
|
|
||
| Documentation under man/ and docs/, and NEWS, remain intentionally | ||
| unchanged. | ||
| --- | ||
| src/boot/stub.c | 1 - | ||
| src/vmspawn/vmspawn.c | 30 +++++------------------------- | ||
| 2 files changed, 5 insertions(+), 26 deletions(-) | ||
|
|
||
| diff --git a/src/boot/stub.c b/src/boot/stub.c | ||
| index 6904d21fd8..98177b1741 100644 | ||
| --- a/src/boot/stub.c | ||
| +++ b/src/boot/stub.c | ||
| @@ -146,7 +146,6 @@ static void export_stub_variables(EFI_LOADED_IMAGE_PROTOCOL *loaded_image, unsig | ||
| EFI_STUB_FEATURE_THREE_PCRS | /* We can measure kernel image, parameters and sysext */ | ||
| EFI_STUB_FEATURE_RANDOM_SEED | /* We pass a random seed to the kernel */ | ||
| EFI_STUB_FEATURE_CMDLINE_ADDONS | /* We pick up .cmdline addons */ | ||
| - EFI_STUB_FEATURE_CMDLINE_SMBIOS | /* We support extending kernel cmdline from SMBIOS Type #11 */ | ||
| EFI_STUB_FEATURE_DEVICETREE_ADDONS | /* We pick up .dtb addons */ | ||
| EFI_STUB_FEATURE_MULTI_PROFILE_UKI | /* We grok the "@1" profile command line argument */ | ||
| EFI_STUB_FEATURE_REPORT_STUB_PARTITION | /* We set StubDevicePartUUID + StubImageIdentifier */ | ||
| diff --git a/src/vmspawn/vmspawn.c b/src/vmspawn/vmspawn.c | ||
| index faac8775d4..650d8778f5 100644 | ||
| --- a/src/vmspawn/vmspawn.c | ||
| +++ b/src/vmspawn/vmspawn.c | ||
| @@ -1860,7 +1860,7 @@ static int run_virtual_machine(int kvm_device_fd, int vhost_device_fd) { | ||
| } | ||
|
|
||
| if (ARCHITECTURE_SUPPORTS_SMBIOS) { | ||
| - _cleanup_free_ char *kcl = strv_join(arg_kernel_cmdline_extra, " "), *escaped_kcl = NULL; | ||
| + _cleanup_free_ char *kcl = strv_join(arg_kernel_cmdline_extra, " "); | ||
| if (!kcl) | ||
| return log_oom(); | ||
|
|
||
| @@ -1868,30 +1868,10 @@ static int run_virtual_machine(int kvm_device_fd, int vhost_device_fd) { | ||
| r = strv_extend_many(&cmdline, "-append", kcl); | ||
| if (r < 0) | ||
| return log_oom(); | ||
| - } else { | ||
| - if (ARCHITECTURE_SUPPORTS_SMBIOS) { | ||
| - escaped_kcl = escape_qemu_value(kcl); | ||
| - if (!escaped_kcl) | ||
| - log_oom(); | ||
| - | ||
| - r = strv_extend(&cmdline, "-smbios"); | ||
| - if (r < 0) | ||
| - return log_oom(); | ||
| - | ||
| - r = strv_extendf(&cmdline, "type=11,value=io.systemd.stub.kernel-cmdline-extra=%s", escaped_kcl); | ||
| - if (r < 0) | ||
| - return log_oom(); | ||
| - | ||
| - r = strv_extend(&cmdline, "-smbios"); | ||
| - if (r < 0) | ||
| - return log_oom(); | ||
| - | ||
| - r = strv_extendf(&cmdline, "type=11,value=io.systemd.boot.kernel-cmdline-extra=%s", escaped_kcl); | ||
| - if (r < 0) | ||
| - return log_oom(); | ||
| - } else | ||
| - log_warning("Cannot append extra args to kernel cmdline, native architecture doesn't support SMBIOS, ignoring"); | ||
| - } | ||
| + } else if (!strv_isempty(arg_kernel_cmdline_extra)) | ||
| + log_warning("Cannot append extra args to kernel cmdline when booting via a boot loader or UKI, " | ||
| + "the SMBIOS Type 11 OEM string mechanism previously used for this is no longer " | ||
| + "supported by sd-boot/the UKI stub, ignoring"); | ||
| } else | ||
| log_warning("Cannot append extra args to kernel cmdline, native architecture doesn't support SMBIOS"); | ||
|
|
||
| -- | ||
| 2.52.0 | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch (as well as 9019 and 9020) is missing a
Signed-off-by:line