update and apply patches for grub and update shim - #197
Closed
sky1122 wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Jingwei Wang <jweiw@amazon.com>
Contributor
Author
|
Build will fail as expected |
Contributor
Author
|
forced pushed to add sign-off for the patches that manually fix the rejection |
Signed-off-by: Jingwei Wang <jweiw@amazon.com>
Contributor
Author
|
forced pushed to add left over sign-off for the patch |
Signed-off-by: Jingwei Wang <jweiw@amazon.com>
Contributor
Author
|
forced pushed to change one commit message |
sky1122
marked this pull request as ready for review
June 17, 2025 00:33
bcressey
reviewed
Jun 17, 2025
| %global mokm_efi_image mm%{_cross_efi_arch}.efi | ||
|
|
||
| %global shimver 15.8 | ||
| %global shimver 16.0 |
Contributor
There was a problem hiding this comment.
You also need to update the commit below this line.
bcressey
reviewed
Jun 17, 2025
Comment on lines
-71
to
-78
| Patch0048: 0048-add-flag-to-only-search-root-dev.patch | ||
| Patch0049: 0049-efi-Add-grub_efi_set_variable_with_attributes.patch | ||
| Patch0050: 0050-include-grub-types.h-Add-GRUB_SSIZE_MAX.patch | ||
| Patch0051: 0051-kern-misc-kern-efi-Extract-UTF-8-to-UTF-16-code.patch | ||
| Patch0052: 0052-efi-Add-grub_efi_set_variable_to_string.patch | ||
| Patch0053: 0053-efi-add-vendor-GUID-for-Boot-Loader-Interface.patch | ||
| Patch0054: 0054-efi-set-LoaderTimeInitUSec-and-LoaderTimeExecUSec.patch | ||
| Patch0055: 0055-tsc-drop-tsc_boot_time-offset.patch |
Contributor
There was a problem hiding this comment.
These patches definitely should not go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #198
Description of changes:
The patches in this serial is for grub6.12 etc upper version of grub not 2.06(the version used in kernel kit). As a result I used patches from Alma because fedora is already in GRUB 2.12. Applying Alma patches, there are 34 patches not applied and after checking there are three patches didn't not exist in the email serial. After checking these 31 patches, manual fixed the rejection, consume extra patches and applied patches. All the patches applied.
Full mitigation against all will require updated shim with latest SBATso I also update theshimIn order to consume the patches there are some extra patches I consumed:
These two patches will not introduce new issue based on what they are doing.
In order to applied the patches, the patches I manual fix to apply are
There are also existing patches that we currently carry already took by upsteam so drop them, detail see the commit (grub: update to grub2-2.06-61.amzn2023.0.18)
there is one patch does not take amount all the upstream so I did not take
so we are not affected by this patch based on the current version is using
idxandElf_Sym *symfrom the caller functiongrub_dl_resolve_symbolsTesting done:
Building the AMI with kernel 6.1, kernel 6.12 to boot and upgrade/downgrade test
boot sucess
upgrade
downgrade
upgrade to
1.41.0downgrade to
1.40.0Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.