Skip to content

tools: add additional version checks to changelog validation - #244

Merged
dhwaniserai merged 1 commit into
bottlerocket-os:developfrom
dhwaniserai:changelog_validation
Sep 10, 2025
Merged

tools: add additional version checks to changelog validation#244
dhwaniserai merged 1 commit into
bottlerocket-os:developfrom
dhwaniserai:changelog_validation

Conversation

@dhwaniserai

@dhwaniserai dhwaniserai commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Add a check to verify that last two versions are not same

Description of changes:

Added the following checks to CHANGELOG validation

  • All release versions are unique
  • All release versions in CHANGELOG are in descending order

Testing done:

  • Validation passed with current CHANGELOG.md
  • Validation failed with duplicate kit versions
  • Validation failed with version in non descending order eg: v4.0.2 before v4.0.1

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@dhwaniserai
dhwaniserai requested review from Copilot and vyaghras and removed request for Copilot August 12, 2025 21:13

@ginglis13 ginglis13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated your testing steps, LGTM

@dhwaniserai

Copy link
Copy Markdown
Contributor Author

force push refers to the following change in validation checks

  • Make sure that versions are in descending order
  • All versions are unique (no duplicates)

@dhwaniserai

Copy link
Copy Markdown
Contributor Author

force push refers to a small change from shellcheck

Comment thread tools/validate-changelog.sh Outdated
Comment thread tools/validate-changelog.sh
Added checks for version format consistency and proper semantic versioning patterns
to ensure changelog entries follow the expected format standards.

Signed-off-by: Dhwani Serai <dhwanise@amazon.com>
@dhwaniserai dhwaniserai changed the title tools: add a version check to changelog validation tools: add additional version checks to changelog validation Sep 10, 2025
@dhwaniserai

Copy link
Copy Markdown
Contributor Author

force push refers to changes resolving the feedback above^

@arnaldo2792 arnaldo2792 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ginglis13 ginglis13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the PR locally, LGTM

@dhwaniserai
dhwaniserai merged commit a8ca6c7 into bottlerocket-os:develop Sep 10, 2025
2 checks passed
@dhwaniserai
dhwaniserai deleted the changelog_validation branch September 10, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants