Skip to content

makefile: remove dependencies from build-variant task #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpkelly wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

makefile: remove dependencies from build-variant task #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion twoliter/embedded/Makefile.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ cargo build \
]

[tasks.build-variant]
dependencies = ["fetch", "build-sbkeys", "publish-setup", "validate-kits"]
dependencies = ["fetch-sdk", "build-sbkeys", "publish-setup", "validate-kits"]

@bcressey bcressey Sep 20, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-variant can also trigger the equivalent of build-package tasks, and for those we do need to run fetch-sources (for first-party sources under sources/) and fetch-vendored (for packages that need bundled Go modules prepared).

script = [
'''
export PATH="${TWOLITER_TOOLS_DIR}:${PATH}"
Expand Down