Fix some ICO files not converting to PNG#4417
Merged
mirkobrombin merged 1 commit intobottlesdevs:mainfrom Mar 20, 2026
Merged
Conversation
Some ICO files are incorrectly identified as TARGA by libmagic file utility, used to obtain the MIME type of the extracted icon from the executable while creating a desktop entry using dynamic launcher portal. They are then assumed to be already PNG, and therefore are not correctly converted, which results in failure to validate the icon by the portal. While this is a libmagic bug, workaround it by assuming that "image/x-tga" MIME type also indicates ICO files. See https://bugs.astron.com/view.php?id=723 Helps: bottlesdevs#4402
mirkobrombin
approved these changes
Mar 20, 2026
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some ICO files are incorrectly identified as TARGA by libmagic file utility, used to obtain the MIME type of the extracted icon from the executable while creating a desktop entry using dynamic launcher portal. They are then assumed to be already PNG, and therefore are not correctly converted, which results in failure to validate the icon by the portal.
While this is a libmagic bug, workaround it by assuming that "image/x-tga" MIME type also indicates ICO files.
See https://bugs.astron.com/view.php?id=723
Helps #4402
Type of change
How Has This Been Tested?