Skip to content

Drop deprecated vars#4435

Open
ndiruhniu wants to merge 1 commit intobottlesdevs:mainfrom
ndiruhniu:patch-1
Open

Drop deprecated vars#4435
ndiruhniu wants to merge 1 commit intobottlesdevs:mainfrom
ndiruhniu:patch-1

Conversation

@ndiruhniu
Copy link
Copy Markdown

Description

DXVK_STATE_CACHE_PATH is no longer used in the current DXVK, so it has been replaced with DXVK_SHADER_CACHE_PATH.

__GL_SHADER_DISK_CACHE_SKIP_CLEANUP is obsolete in modern Mesa.

__GL_SHADER_DISK_CACHE_PATH is obsolete in modern systems, as it is handled through Mesa via MESA_SHADER_CACHE_DIR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It has not been tested, but nothing should break.

DXVK_STATE_CACHE_PATH is no longer used in the current DXVK, so it has been replaced with DXVK_SHADER_CACHE_PATH.

__GL_SHADER_DISK_CACHE_SKIP_CLEANUP is obsolete in modern Mesa.

__GL_SHADER_DISK_CACHE_PATH is obsolete in modern systems, as it is handled through Mesa via MESA_SHADER_CACHE_DIR
Copy link
Copy Markdown
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot simply drop them, Bottles provides older versions too. Both must be supported

@ndiruhniu
Copy link
Copy Markdown
Author

This does not break compatibility with previous versions. The removed OpenGL cache flags cannot break anything, and DXVK has been using DXVK_SHADER_CACHE_PATH instead of STATE cache since version 2.7. Even if an old DXVK and Mesa are used, it will not harm the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants