Skip to content

feat(annotations): pass rich-text flag on fetch GET - #782

Draft
jmcbgaston wants to merge 1 commit into
box:masterfrom
jmcbgaston:enable-rich-text-annotation-fetch
Draft

feat(annotations): pass rich-text flag on fetch GET#782
jmcbgaston wants to merge 1 commit into
box:masterfrom
jmcbgaston:enable-rich-text-annotation-fetch

Conversation

@jmcbgaston

Copy link
Copy Markdown
Contributor

Description

fetchAnnotationsAction passes isRichTextEnabled as the last argument to getAnnotations. PopupV2 reads that store collection, not the sidebar file_activities payload.

Quirk: the arg is optional on the client so flag-off and older callers omit the key. Create, update, and delete stay param-free.

Popup reads this store fetch, not the sidebar file-activities payload.
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jose Gaston seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants