chore: Adjust build for combined SDK#1003
Merged
lukaszsocha2 merged 6 commits intocombined-sdkfrom Sep 15, 2025
Merged
Conversation
Contributor
Author
|
Some changes in manual files were required to pass pylint check due to upgrade from Python 3.6 to 3.8 (they modify rules with every new version) |
lukaszsocha2
commented
Sep 12, 2025
| @@ -1,28 +0,0 @@ | |||
| # A GitHub action that notifies the developer | |||
Contributor
Author
There was a problem hiding this comment.
This workflow is triggered only on default branch, so there is no point in keeping it here
arjankowski
reviewed
Sep 15, 2025
| 'client_id': client_id, | ||
| 'client_secret': client_secret, | ||
| }, | ||
| timeout=10, |
Contributor
There was a problem hiding this comment.
Why did you have to add timeout here?
Contributor
Author
There was a problem hiding this comment.
This was required by pylint to specify timeout to every http request, otherwise it can last forever. It is consider as a good practice
arjankowski
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.