Skip to content

feat(router): SidebarPanel now has routerles version #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafalmaksymiuk wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(router): SidebarPanel now has routerles version #4218

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5337fab
feat(router): SidebarPanel now has routerles version
rafalmaksymiuk Aug 5, 2025
70adf55
feat(router): All Unit Tests converted to RTL
rafalmaksymiuk Aug 6, 2025
3d9d9d0
feat(router): Added unit tests for routerDisabled version.
rafalmaksymiuk Aug 7, 2025
24a1943
feat(router): Fix after review and fixed Flow errors
rafalmaksymiuk Aug 7, 2025
f563056
feat(router): Fix after review and fixed Flow errors
rafalmaksymiuk Aug 7, 2025
e628aec
feat(router): Small style fix
rafalmaksymiuk Aug 11, 2025
46d454a
feat(router): SidebarPanel small updates after review
rafalmaksymiuk Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/elements/common/types/SidebarNavigation.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ export const ViewType = Object.freeze({
METADATA_REDESIGN: 'metadata_redesign',
SKILLS: 'skills',
ACTIVITY: 'activity',
VERSIONS: 'versions',
DOCGEN: 'docgen',
});

export const FeedEntryType = Object.freeze({
ANNOTATIONS: 'annotations',
COMMENTS: 'comments',
TASKS: 'tasks',
VERSIONS: 'versions',
});

export type ViewTypeValues = $Values<typeof ViewType>;
Expand All @@ -27,13 +27,14 @@ export type SidebarNavigation = {
activeFeedEntryType?: FeedEntryTypeValues,
activeFeedEntryId?: string,
fileVersionId?: string,
filteredTemplateIds?: string,
sidebar: ViewTypeValues,
filteredTemplateIds?: string[],
sidebar?: ViewTypeValues,
versionId?: string,
};

export type InternalSidebarNavigation = SidebarNavigation & {
open?: boolean,
silent?: boolean,
};

export type SidebarNavigationHandler = (sidebar: SidebarNavigation, replace?: boolean) => void;
Expand Down
10 changes: 6 additions & 4 deletions src/elements/common/types/SidebarNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,25 @@ export enum ViewType {
METADATA_REDESIGN = 'metadata_redesign',
BOXAI = 'boxai',
ACTIVITY = 'activity',
VERSIONS = 'versions',
DOCGEN = 'docgen',
}

export enum FeedEntryType {
ANNOTATIONS = 'annotations',
COMMENTS = 'comments',
TASKS = 'tasks',
VERSIONS = 'versions',
}

type VersionSidebarView = {
sidebar: ViewType.ACTIVITY | ViewType.DETAILS;
versionId: string;
activeFeedEntryType: FeedEntryType.VERSIONS;
versionId?: string;
};

export type MetadataSidebarView = {
sidebar: ViewType.METADATA | ViewType.METADATA_REDESIGN;
filteredTemplateIds?: string;
filteredTemplateIds: string[];
};

export type ActivityAnnotationsSidebarView = {
Expand All @@ -39,7 +40,7 @@ type ActivityCommentsSidebarView = {

export type SidebarNavigation =
| {
sidebar: ViewType;
sidebar?: ViewType;
}
| VersionSidebarView
| MetadataSidebarView
Expand All @@ -48,6 +49,7 @@ export type SidebarNavigation =

export type InternalSidebarNavigation = SidebarNavigation & {
open?: boolean;
silent?: boolean;
};

export type SidebarNavigationHandler = (sidebar: SidebarNavigation, replace?: boolean) => void;
Expand Down
Loading