fix: Fix Popover Width and Error Field Spacing#1815
Merged
Conversation
jaxdesmarais
reviewed
Jun 5, 2026
jaxdesmarais
left a comment
jaxdesmarais
left a comment
Contributor
There was a problem hiding this comment.
Are you able to a some screenshots of a few different device widths to the PR description?
jaxdesmarais
reviewed
Jun 5, 2026
jaxdesmarais
approved these changes
Jun 8, 2026
agedd
reviewed
Jun 9, 2026
| @State private var containerWidth: CGFloat = CardFieldsConstants.defaultContainerWidth | ||
| private var onValidityChange: ((Bool, @escaping () -> Void) -> Void)? | ||
|
|
||
| private var useHorizontalLayout: Bool { containerWidth >= CardFieldsConstants.horizontalLayoutThreshold } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Screenshots:
iPhone SE from Preview (raw CardField with no additional styling-takes up entire width and allows merchants to control desired width with the container view)
iphone SE from Demo view (width padding like a merchant may add)
iPhone 17
iPad Pro 13inch
AI Usage
Which AI Agent Was Used?
How was AI used?
Used to determine pros and cons of specific ways of fixing width issue as well as make changes for adding in the passing of containerWidth
Estimated AI Code Contribution
Checklist
Authors