Card fields analytics #1817
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,43 @@ | ||||||
| import XCTest | ||||||
| import BraintreeCard | ||||||
| import BraintreeCore | ||||||
| @testable import BraintreeTestShared | ||||||
| @testable import BraintreeUIComponents | ||||||
|
|
||||||
| @MainActor | ||||||
| final class CardFieldsViewModelTests: XCTestCase { | ||||||
|
|
||||||
| private var mockAPIClient = MockAPIClient(authorization: "development_testing_tokenization_key_sandbox") | ||||||
| private var viewModel = CardFieldsViewModel( | ||||||
|
Contributor
There was a problem hiding this comment. nit: it looks like we're initializing the same on line 19
Suggested change
|
||||||
| authorization: "development_testing_tokenization_key_sandbox", | ||||||
| card: BTCard() | ||||||
| ) { _, _ in } | ||||||
|
|
||||||
| override func setUp() { | ||||||
| super.setUp() | ||||||
| mockAPIClient = MockAPIClient(authorization: "development_testing_tokenization_key_sandbox") | ||||||
| viewModel = CardFieldsViewModel( | ||||||
| authorization: "development_testing_tokenization_key_sandbox", | ||||||
| card: BTCard() | ||||||
| ) { _, _ in } | ||||||
| viewModel.apiClient = mockAPIClient | ||||||
| } | ||||||
|
|
||||||
| // MARK: - Analytics | ||||||
|
|
||||||
| func testSendAnalyticsEvent_cardFieldsPresented_postsCorrectEvent() { | ||||||
| viewModel.sendAnalyticsEvent(UIComponentsAnalytics.cardFieldsPresented) | ||||||
|
|
||||||
| XCTAssertTrue(mockAPIClient.postedAnalyticsEvents.contains(UIComponentsAnalytics.cardFieldsPresented)) | ||||||
| } | ||||||
|
|
||||||
| func testTokenize_whenFormIsValid_postsSubmittedEvent() { | ||||||
| viewModel.cardNumberViewModel.updateValue("4111111111111111") | ||||||
| viewModel.expirationDateViewModel.updateValue("12/45") | ||||||
| viewModel.cvvViewModel.updateValue("123") | ||||||
|
|
||||||
| viewModel.tokenize() | ||||||
|
|
||||||
| XCTAssertTrue(mockAPIClient.postedAnalyticsEvents.contains(UIComponentsAnalytics.cardFieldsSelected)) | ||||||
| } | ||||||
| } | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be private 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yep! Good call thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually sorry it is exposed for testing like the current pattern for the other clients. I moved and added docstring to follow existing pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comment and Jax's below sort of intersected, so ended up changing this up