Pin SwiftLint to 0.55.1 in Lint Workflow#1819
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities found.Scanned FilesNone |
The lint workflow installed SwiftLint via an unpinned `brew install`, which recently pulled 0.63.3. That version changed the `force_unwrapping` rule so it no longer triggers on several Demo files, making their existing `swiftlint:disable` comments superfluous. Under `--strict`, `superfluous_disable_command` then failed lint on unrelated PRs. Pin to 0.55.1 (the version documented in .swiftlint.yml and CLAUDE.md) by installing the official SwiftLint release binary, so CI lint is reproducible. A loose homebrew-core formula file can't be used because current Homebrew rejects formulae that aren't in a tap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jaxdesmarais
force-pushed
the
ci/pin-swiftlint-0.55.1
branch
from
3412750 to
93330ec
Compare
buzzamus
approved these changes
Jun 10, 2026
| # via the official release binary. An unpinned `brew install` pulls the | ||
| # latest SwiftLint, which breaks `--strict` lint on unrelated PRs, and | ||
| # current Homebrew refuses to install a formula from a loose file path. | ||
| run: | |
Contributor
There was a problem hiding this comment.
Thank you for this comment. Helps explain the issue and fix perfectly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The lint workflow installed SwiftLint via an unpinned
brew install, which recently pulled 0.63.3. That version changed theforce_unwrappingrule so it no longer triggers on several Demo files, making their existingswiftlint:disablecomments superfluous. Under--strict,superfluous_disable_commandthen failed lint on unrelated PRs.Pin to 0.55.1 (the version documented in .swiftlint.yml and CLAUDE.md) by installing the homebrew-core formula at the commit for that version, so CI lint is reproducible.
AI Usage
Which AI Agent Was Used?
How was AI used?
Used to triage and troubleshoot issue
Estimated AI Code Contribution
Checklist
[ ] Added a changelog entry[ ] Tested and confirmed payment flows affected by this change are functioning as expectedAuthors