Fix CVV validation error state#1822
Merged
Merged
Conversation
buzzamus
changed the title
agedd
reviewed
Jun 18, 2026
|
|
||
| Publishers.CombineLatest3(cardValid, expValid, cvvValid) | ||
| .map { $0 && $1 && $2 } | ||
| .removeDuplicates() |
Contributor
There was a problem hiding this comment.
curious why we added this check here 👀
Contributor
Author
There was a problem hiding this comment.
This ignores duplicates of the same validity, so for example if the form is valid, more typing occurs, and the form is still valid it does not have to re-render the view, which avoids stuttering issues for the CVV masking
agedd
reviewed
Jun 18, 2026
agedd
left a comment
agedd
left a comment
Contributor
There was a problem hiding this comment.
would you be able to attach a screen recording of this validation check/fix in effect
agedd
reviewed
Jun 18, 2026
| } | ||
|
|
||
|
|
||
| // MARK: - updateExpectedLength |
Contributor
Author
Updated description with video of the fix! |
jaxdesmarais
approved these changes
Jun 18, 2026
jaxdesmarais
left a comment
jaxdesmarais
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this bug and adding tests for it as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Simulator.Screen.Recording.-.iPhone.17.-.2026-06-18.at.10.25.25.mov
AI Usage
Which AI Agent Was Used?
How was AI used?
Track down cause of laggy CVV typing, write unit tests
Estimated AI Code Contribution
Checklist
Authors