fix: fallback for URL.canParse missing in some environments (#92)#93
Open
Shaharyar07 wants to merge 1 commit into
Open
fix: fallback for URL.canParse missing in some environments (#92)#93Shaharyar07 wants to merge 1 commit into
Shaharyar07 wants to merge 1 commit into
Conversation
|
Running into the same problem, can this be merged? |
|
Chiming in: this issue unfortunately causes issues for apps that haven't polyfilled this web feature, as well as for people who haven't upgrade Browserless PDF generation Chrome versions lately. Thank you to those who made the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds a safe fallback when URL.canParse is not available in the runtime environment.
Some environments (older Node.js / browsers) do not implement URL.canParse, which caused sanitizeUrl to throw a TypeError.
Checklist
Authors
@Shaharyar07
Reviewers
@braintree/team-sdk-js