Matt/script py release#695
Merged
Merged
Conversation
this simpflies our noxfile a lot.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Matt Perpick (clutchski)
requested review from
Hurshal Patel (choochootrain) and
Olmo Maldonado (ibolmo)
Hurshal Patel (choochootrain)
approved these changes
May 15, 2025
Hurshal Patel (choochootrain)
left a comment
Hurshal Patel (choochootrain)
left a comment
Contributor
There was a problem hiding this comment.
thank you for your service 🫡
left some nits but nothing blocking
Comment on lines
+50
to
+51
| # FIXME[matt] remove this once we're onmain | ||
| # exit 1 |
Contributor
There was a problem hiding this comment.
im assuming you'll do this in a followup PR?
Collaborator
Author
There was a problem hiding this comment.
yes
| if [[ "$OSTYPE" == "darwin"* ]]; then | ||
| sed -i '' "$@" | ||
| else | ||
| sed -i "$@" |
Contributor
There was a problem hiding this comment.
gnu sed is best sed
Comment on lines
+47
to
+49
| - name: Validate release tag | ||
| run: | | ||
| ./py/scripts/validate-release-tag.sh "$RELEASE_TAG" |
Contributor
There was a problem hiding this comment.
There appears to be a mismatch in how the RELEASE_TAG is passed to the validation script. The script validate-release-tag.sh expects RELEASE_TAG as an environment variable, but it's being passed as a command-line argument.
To fix this, consider changing the line to:
RELEASE_TAG=$RELEASE_TAG ./py/scripts/validate-release-tag.shThis ensures the script receives the value through the environment as expected.
Suggested change
| - name: Validate release tag | |
| run: | | |
| ./py/scripts/validate-release-tag.sh "$RELEASE_TAG" | |
| - name: Validate release tag | |
| run: | | |
| RELEASE_TAG=$RELEASE_TAG ./py/scripts/validate-release-tag.sh |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR automates the release of the python SDK and cleans up our python make targets a bit.
Caveats
test.pypi.orgtest.pypi.org). Currently this runs on PRs, but that's just to test it. I'll remove it before merging.Usage
How you'd do a release:
version.pyand merge the PR to mainThis triggers the
autopublishworkflow, which is watching for pushes to tags likevXYZ. This job does some validation that the tag is sane, matchesversion.pyand then builds the wheel, tests the wheel and publishes totestpypi.If this works, I'll add PyPI soon.