Using messages from ZF validators + fix buildInlineJavascript for arrays, functions + added (commented for now additional-methods JS)#50
Open
cbichis wants to merge 12 commits into
Open
Conversation
…es for value_options
bramstroker
reviewed
May 31, 2017
| return [ | ||
| 'range' => | ||
| sprintf($this->translateMessage('The input is not between %s and %s'), $this->getMin($validator), $this->getMax($validator)) | ||
| 'range' => sprintf($validator->getMessageTemplates()[\Zend\Validator\Between::NOT_BETWEEN], $this->getMin($validator), $this->getMax($validator)) |
Owner
There was a problem hiding this comment.
This message need to be passed through the translator. You can use the same method as before $this->translateMessage()
| if ($options->getIncludeAssets()) { | ||
| $assetBaseUri = $this->getHttpRouter()->assemble([], ['name' => 'strokerform-asset']); | ||
| $inlineScript->appendFile($assetBaseUri . '/jquery_validate/js/jquery.validate.js'); | ||
| //$inlineScript->appendFile($assetBaseUri . '/jquery_validate/js/additional-methods.min.js'); |
Owner
There was a problem hiding this comment.
Please include the asset and don't remove this line
| $value = (is_string($value)) ? $value : var_export($value, true); | ||
|
|
||
| if(is_string($value)){ | ||
| if(strpos($value, 'function') === 0){ |
Owner
There was a problem hiding this comment.
Could you add a unit test for this case please? Than we can also see if we can improve this code a little because it is a littlebit messy now with all these if / else statements.
Author
There was a problem hiding this comment.
I am not very familiar with unit tests unfortunatelly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.