Fix build for recent XCode versions - #32
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Sparkle’s Xcode build settings by increasing the macOS deployment target to a version supported by newer Xcode toolchains, aligning the project with more modern macOS baselines.
Changes:
- Bumped
MACOSX_DEPLOYMENT_TARGETfrom10.9to10.13in the shared/common build configuration. - Bumped
MACOSX_DEPLOYMENT_TARGETfrom10.9to10.13for the unit test configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Configurations/ConfigCommon.xcconfig |
Raises the project-wide macOS deployment target to improve compatibility with newer Xcode versions. |
Configurations/ConfigUnitTest.xcconfig |
Raises the unit test bundle deployment target to match the newer baseline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| GCC_INLINES_ARE_PRIVATE_EXTERN = YES | ||
| ARCHS = $(ARCHS_STANDARD) | ||
| MACOSX_DEPLOYMENT_TARGET = 10.9 | ||
| MACOSX_DEPLOYMENT_TARGET = 10.13 |
| FRAMEWORK_SEARCH_PATHS = $(inherited) $(DEVELOPER_FRAMEWORKS_DIR) | ||
| LD_RUNPATH_SEARCH_PATHS = @loader_path/../Frameworks | ||
| MACOSX_DEPLOYMENT_TARGET = 10.9 | ||
| MACOSX_DEPLOYMENT_TARGET = 10.13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be safe because the minimum deployment target for Chromium (and thus Brave) is macOS 12, which is higher than 10.13.