Multiple AWS accounts support + SG count fix + route count fix#46
Open
alikhanich wants to merge 5 commits intobrennerm:masterfrom
Open
Multiple AWS accounts support + SG count fix + route count fix#46alikhanich wants to merge 5 commits intobrennerm:masterfrom
alikhanich wants to merge 5 commits intobrennerm:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is the proposal to add multiple AWS account support via
~/.aws/folder and config files. Currently it breaks backwards compatibility, but I can fix it, if you are OK with those changes.Routes were not calculated propely, Quota in AWS only applied to user created routes, not all routes. We also had routes created by VPG, and this is not goes into quota.
Also security groups count was not working as it should. AWS data structure is misleading, for example if you have multiple network masks for
sg['IpPermissions']it actually counts asnumber of networksnot as one rule upon quota.