Skip to content

Explicit JPMS support #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vietj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicit JPMS support #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<dependencies>
<dependency>
<groupId>net.java.dev.jna</groupId>
<artifactId>jna</artifactId>
<artifactId>jna-jpms</artifactId>

@bturner bturner Jun 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mildly concerned about this change. Other codebases that leverage NuProcess may have dependency managed jna, but may or may not have an entry for jna-jpms. They'd either need to exclude it, or switch their configuration over, to avoid getting both jna and jna-jpms (and potentially at different versions).

I'm not sure there's any good way around this, here in NuProcess's POM, but at a minimum this seems like something we should at least mention in CHANGES.md to try and raise visibility for consumers.

<version>5.11.0</version>
</dependency>

Expand Down Expand Up @@ -167,6 +167,11 @@
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>1.6.12</version>
</plugin>
<plugin>
<groupId>io.github.dmlloyd.module-info</groupId>
<artifactId>module-info</artifactId>
<version>2.0</version>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand All @@ -185,7 +190,7 @@
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>com.zaxxer.nuprocess</Automatic-Module-Name>
<Multi-Release>true</Multi-Release>
</manifestEntries>
</archive>
</configuration>
Expand Down Expand Up @@ -218,6 +223,22 @@
</instructions>
</configuration>
</plugin>
<plugin>
<groupId>io.github.dmlloyd.module-info</groupId>
<artifactId>module-info</artifactId>
<executions>
<execution>
<id>module-info</id>
<phase>process-classes</phase>
<configuration>
<outputDirectory>${project.build.outputDirectory}/META-INF/9</outputDirectory>
</configuration>
<goals>
<goal>generate</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
10 changes: 10 additions & 0 deletions src/main/java/module-info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: com.zaxxer.nuprocess
requires:
- module: com.sun.jna
exports:
- package: com.zaxxer.nuprocess
- package: com.zaxxer.nuprocess.codec
- package: com.zaxxer.nuprocess.internal

@bturner bturner Jun 7, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think internal, linux, osx and windows should likely not be exported. They're all intended to be implementation details of using the API defined in com.zaxxer.nuprocess. For whatever use case(s) you're trying to support, is there a reason you're using those packages?

- package: com.zaxxer.nuprocess.linux
- package: com.zaxxer.nuprocess.osx
- package: com.zaxxer.nuprocess.windows