Enable getrandom support for Emscripten - #2877
Open
guybedford wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
SystemRandomonwasm32-unknown-emscripten.getrandom0.4 implements Emscripten via libcgetentropy, which Emscripten's runtime backs withcrypto.getRandomValues, so this is the environment's CSPRNG rather than a custom orrdrandimplementation, matching the criterion for the existingtarget_oslist.target_os = "emscripten"to theSystemRandomcfg insrc/rand.rs.No
build.rschanges were needed; the existing wasm32 C build works as-is withCC=emcc AR=emar.Tested locally with Emscripten 6.0.10 and Node 22:
cargo test --target wasm32-unknown-emscriptenwithCARGO_TARGET_WASM32_UNKNOWN_EMSCRIPTEN_RUNNER=nodepasses the full suite includingrand_testsand doctests.