Fix: Unsupported audio Renderer #818
Open
rga-medix wants to merge 1 commit into
Open
Conversation
…fmpeg.FfmpegAudioRenderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using ExoMedia and want to use the FFmpeg Audio Renderers.
I faced this Exception:
AudioRenderProvider: Unsupported audio Renderer class class androidx.media3.decoder.ffmpeg.FfmpegAudioRenderer
AudioRenderProvider.buildRenderer and VideoRenderProvider.buildRenderer use a when (Class.forName(className)) { DecoderAudioRenderer::class.java -> … } match. Because Class<*> equality is reference-equality, this branch is only ever taken when className is literally androidx.media3.exoplayer.audio.DecoderAudioRenderer.
Therefore all subclasses such as the FfmpegAudioRenderer, LibflacAudioRenderer, LibopusAudioRenderer, Libgav1VideoRenderer, LibvpxVideoRenderer) are rejected.
This commit fixes the broken extension support.
Closes #816