fix(terraform): CKV_AWS_382 false positive on aws_vpc_security_group_egress_rule with ip_protocol=-1#7513
Open
jathinsn27 wants to merge 3 commits intobridgecrewio:mainfrom
Conversation
…egress_rule with ip_protocol=-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
CKV_AWS_382 was silently passing wide-open egress rules written against the newer
aws_vpc_security_group_egress_ruleresource whenever ip_protocol was set to -1 and the from_port or to_port arguments were omitted.Fixes #7372
Fix
contains_violationon the new-resource branch.protocolorip_protocol.ip_protocol="-1"with no ports to the full0-65535range.cidr_ipv4list-unwrapping pattern forcidr_ipv6.Checklist: