feat: extract samplingProcedure and extrapolations when collapse_comments=False#347
Merged
Merged
Conversation
…ents=False When collapse_comments=False, Ecospold2DataExtractor.extract_activity now also returns modeling_summary (from modellingAndValidation/representativeness/ samplingProcedure) and data_handling_summary (from .../extrapolations). These fields are absent from the dict when collapse_comments=True, preserving backwards compatibility with existing callers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collapse_comments=False,Ecospold2DataExtractor.extract_activitynow returns two additional keys:modeling_summary←modellingAndValidation/representativeness/samplingProceduredata_handling_summary←modellingAndValidation/representativeness/extrapolationsNonewhen the element is absent or empty.collapse_comments=True, preserving backwards compatibility.Test plan
test_collapse_comments_falseextended to assert both new keys have the expected text from the existing fixture (which already hadsamplingProcedureandextrapolations)test_collapse_comments_true_omits_repr_fieldsadded to confirm keys are absent in default mode