Skip to content

Km testing popups#1

Draft
kiley-mitti wants to merge 11 commits into
mainfrom
km-testing-popups
Draft

Km testing popups#1
kiley-mitti wants to merge 11 commits into
mainfrom
km-testing-popups

Conversation

@kiley-mitti

Copy link
Copy Markdown
Collaborator

check this out. it doesn't fix it but it does replicate the issue I think you're experiencing and displays the problem.

@brikiernan

Copy link
Copy Markdown
Owner

yup, it's saying, let me out! Thanks for looking into this.

@brikiernan brikiernan left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you see if you can get this example to work. please?

I made the placement top and unset the overflow, but it's still a bit messy.

@brikiernan

Copy link
Copy Markdown
Owner

rows 4 and beyond work, but rows 1 - 3 are under part of the table, row or something.

@kiley-mitti

Copy link
Copy Markdown
Collaborator Author

If I unset overflow for everything in the project then the popovers work as expected (and placement top is respected for all of them). So there is some part of AG grid overflow: hidden that is still causing weirdness. Still looking into the weird stuff when placement is bottom. :)

@kiley-mitti

kiley-mitti commented Nov 10, 2022

Copy link
Copy Markdown
Collaborator Author

OK! So, the reason pop-up does weird things in this scenario is actually a css quirk. AGGrid uses the css transform property to display rows. However, when you give an element the transform property it moves it into its very own z-index group. So aggrid wasn't respecting the index set by pop-up. AGGrid Options the option: suppressRowTransform turns off this behavior so z-indexing works the way you would expect it to. With this and ag-cell-value overflow: unset you should get this working exactly as it should.

That said, even though there is a solution is was tough to figure out. It's worth looking into changing the way rux-pop-up renders the pop-up

@brikiernan

Copy link
Copy Markdown
Owner

Thanks for looking into this Kiley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants