Skip to content

Add ADIN link and MAC stats metrics - #154

Merged
Davidbick merged 1 commit into
mainfrom
feature/adin_metrics_mac
Aug 11, 2026
Merged

Add ADIN link and MAC stats metrics#154
Davidbick merged 1 commit into
mainfrom
feature/adin_metrics_mac

Conversation

@Davidbick

Copy link
Copy Markdown
Contributor

What changed?

  • Adds 13 fields to the per-port adin_port_stats_* component: MAC drop counters (dropfull, dropfilt), MAC errors (crc, lserr, phye), traffic/flow counts (rxfrm/txfrm/rxbc/txbc/rxmc/txmc), link state (link), and the frame-check denominator (fcfrm).

How does it make Bristlemouth better?

  • Adds extra visibility into what the network actually drops and how traffic flows: congestion vs. filtering vs. corruption, control- vs. data-plane volume, authoritative link state.

Where should reviewers focus?

  • Payload size: the component grew 8 to 21 fields/port

Checklist

  • Add or update unit tests for changed code
  • Ensure all submodules up to date. If this PR relies on changes in submodules, merge those PRs first, then point this PR at/after the merge commit
  • Ensure code is formatted correctly with clang-format. If there are large formatting changes, they should happen in a separate whitespace-only commit on this PR after all approvals.

@Davidbick Davidbick self-assigned this Aug 10, 2026

@victorsowa12 victorsowa12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Davidbick
Davidbick merged commit c15e6b1 into main Aug 11, 2026
3 checks passed
@Davidbick
Davidbick deleted the feature/adin_metrics_mac branch August 11, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants