Add support to collapse JavaStackTrace into a single event#39
Conversation
62c228b to
011e7b7
Compare
| def test_java_stacktrace(): | ||
| parser = ParserFactory.get_parser(CLOUDWATCH_LOG_TYPE, None) | ||
| parsed = parser.parse(JAVA_STACK_TRACE) | ||
| assert True |
There was a problem hiding this comment.
Good spot. I didn't realise that Claude Code changed tests there. I didn't ask it to! I'll fix it up.
| """ Inspired from https://www.elastic.co/docs/reference/beats/filebeat/multiline-examples#_java_stack_traces """ | ||
|
|
||
| def __init__(self): | ||
| self.lines = Queue(maxsize=2) |
There was a problem hiding this comment.
this seems small? im presuming this is the number of lines in the stacktrace?
There was a problem hiding this comment.
I need to rename or introduce an intermediary class as I agree that the current implementation doesn't help understand the intent.
There was a problem hiding this comment.
I changed the Aggregator class API. We can probably do better still but at least it should be clearer now. The bottom line is that we keep a line in the aggregator that is not ready to be consumed until we know that the aggregation is completed. In general, the aggregation for a line is complete if we the next doesn't look like a stacktrace one. We also need to complete the aggregation for the last line encountered, as there is no next one in that case.
| self.batch.reset() | ||
| self.aggregator.add_line(None) # poison pill | ||
| _line = self.aggregator.get_line() | ||
| if _line is not None: |
There was a problem hiding this comment.
| if _line is not None: | |
| if _line: |
011e7b7 to
3993a7f
Compare
4 participants
This change introduces an aggregator that collapse Java stack traces split over multiple line into a single one. It is a best effort, assuming that the events of the split stack trace will be provided (e.g. by Cloudwatch) consecutively.
This change also automates the running of this project unit tests.
Tested in a dev environment:
