Skip to content

BRONTO-2553 - do not retry in case of bad request/unauthorized #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoaquilanti wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BRONTO-2553 - do not retry in case of bad request/unauthorized #43

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d2bbc
BRONTO-2553 - do not retry in case of bad request/unauthorized
Apr 1, 2026
514036e
BRONTO-2553 - handle exceptions
Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions log_forwarder/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ def reset(self):

class BrontoClient:

NON_RETRYABLE_STATUS_CODES = {400, 401, 403, 404, 405, 410, 422}

def __init__(self, api_key, ingestion_endpoint, dataset, collection, client_type, tags: Dict[str, str]):
self.api_key = api_key
self.dataset = dataset
Expand All @@ -75,21 +77,23 @@ def __init__(self, api_key, ingestion_endpoint, dataset, collection, client_type
if self.client_type is not None:
self.headers.update({'x-bronto-client': self.client_type})

def _send_batch(self, compressed_batch):
def _send_batch(self, compressed_batch, attempt=0):
request = urllib.request.Request(self.ingestion_endpoint, data=compressed_batch, headers=self.headers)
attempt = 0
max_attempts = 5
with urllib.request.urlopen(request) as resp:
if resp.status != 200 and attempt < max_attempts:
if resp.status == 200:
logger.info('data sent successfully. collection=%s, dataset=%s, tags=%s', self.collection,
self.dataset, self.formatted_tags)
elif resp.status in self.NON_RETRYABLE_STATUS_CODES:
logger.error('Non-retryable error encountered. status=%s, reason=%s', resp.status, resp.reason)
raise Exception(f'BrontoClientNonRetryableError: HTTP {resp.status}')
elif attempt < max_attempts:
attempt += 1
delay_sec = attempt * 10
logger.warning('Data sending failed. attempt=%s, max_attempts=%s, status=%s, reason=%s',
attempt, max_attempts, resp.status, resp.reason)
time.sleep(delay_sec)
self._send_batch(compressed_batch)
elif resp.status == 200:
logger.info('data sent successfully. collection=%s, dataset=%s, tags=%s', self.collection,
self.dataset, self.formatted_tags)
self._send_batch(compressed_batch, attempt)
else:
logger.error('max attempts reached. attempt=%s, max_attempts=%s', attempt, max_attempts)
raise Exception('BrontoClientMaxAttemptReached')
Expand Down
Loading