refactor: improve version stability#45
Merged
Merged
Conversation
swwind
changed the title
swwind
changed the title
swwind
changed the title
Contributor
Author
|
@g-plane please take a look at this pr now. |
Member
|
We don't need to commit |
Contributor
Author
|
This PR was just a proposal for better version management, but I think it might not be worth it if we also want to merge #46. The baseline-browser-mapping package does not have a well-structured format for scraping data from its published version on npm. In fact, if we don't want to introduce automatic update scripts for this project, leaving version management as a manual process isn't a huge problem. |
Member
|
Can we open an issue about this in https://github.com/web-platform-dx/baseline-browser-mapping ? For example, ask them to produce machine-readable format. |
g-plane
approved these changes
Jul 5, 2026
Co-authored-by: Pig Fang <g-plane@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the version management is not great aligned with the js version, and
cargo testfails if any of the 3 dependencies' versions mismatch. Besides,caniuse(used by this) andcaniuse-lite(used by js version) does not always keep in sync even with the similar versions. (the first one does not seems to have every version published on npm exist on github)This PR adjusted the current data generating strategies, we just copy data directly from
node_modules, for better tests with the js version.vendornode_modulesSteps for next data update: just run
pnpm updateand that's done.