Skip to content

Create integration test bed with unhappy scenario - #59

Merged
napoly merged 1 commit into
btcpay-monero:masterfrom
napoly:fix-partial-view-load-up-multiple-integration-tests
Nov 25, 2025
Merged

Create integration test bed with unhappy scenario#59
napoly merged 1 commit into
btcpay-monero:masterfrom
napoly:fix-partial-view-load-up-multiple-integration-tests

Conversation

@napoly

@napoly napoly commented Nov 11, 2025

Copy link
Copy Markdown
Member

Pls note the EnableMoneroPluginSuccessfullySecond should fail as the it is just a copy of the first one and the first does create the wallet file with keys.. but either way it should be able to load the menu etc.. (shouldn't be failing on partial view not found)

@napoly

napoly commented Nov 11, 2025

Copy link
Copy Markdown
Member Author

related btcpayserver/btcpayserver#6985

@napoly
napoly force-pushed the fix-partial-view-load-up-multiple-integration-tests branch 4 times, most recently from 64d18be to 5f4ab0e Compare November 18, 2025 19:21
@napoly

napoly commented Nov 20, 2025

Copy link
Copy Markdown
Member Author

related to btcpayserver/btcpayserver#7008

@napoly
napoly force-pushed the fix-partial-view-load-up-multiple-integration-tests branch 2 times, most recently from 3847d87 to 4d7c2cf Compare November 21, 2025 21:48
@codacy-production

codacy-production Bot commented Nov 21, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.73% (target: -1.00%) 64.29%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cdfdb2c) 951 540 56.78%
Head commit (5bfb9fb) 979 (+28) 563 (+23) 57.51% (+0.73%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#59) 28 18 64.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@napoly
napoly force-pushed the fix-partial-view-load-up-multiple-integration-tests branch 3 times, most recently from 59905ac to 04900c0 Compare November 22, 2025 13:43
@napoly
napoly marked this pull request as ready for review November 22, 2025 15:32
@napoly napoly changed the title Simulate partial Razor view load up failure Create integration test bed with unhappy scenario Nov 22, 2025
Comment thread Plugins/Monero/Services/MoneroRPCProvider.cs Outdated
@napoly
napoly force-pushed the fix-partial-view-load-up-multiple-integration-tests branch from 04900c0 to e1dc030 Compare November 25, 2025 08:54
@napoly
napoly force-pushed the fix-partial-view-load-up-multiple-integration-tests branch from e1dc030 to 5bfb9fb Compare November 25, 2025 09:00
@napoly
napoly merged commit 1ae5455 into btcpay-monero:master Nov 25, 2025
2 checks passed
@napoly
napoly deleted the fix-partial-view-load-up-multiple-integration-tests branch November 25, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants