Simulate subaddress generate duplication - #61
Open
napoly wants to merge 1 commit into
Open
Conversation
napoly
force-pushed
the
simulate-subaddress-duplicate-key-violation
branch
2 times, most recently
from
November 26, 2025 11:28
9b132b9 to
2cfc4ed
Compare
napoly
force-pushed
the
simulate-subaddress-duplicate-key-violation
branch
from
April 1, 2026 21:19
2cfc4ed to
70f516d
Compare
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 1 medium |
| ErrorProne | 21 critical |
🟢 Metrics 0 complexity · 2 duplication
Metric Results Complexity 0 Duplication 2
TIP This summary will be updated as you push new changes. Give us feedback
napoly
force-pushed
the
simulate-subaddress-duplicate-key-violation
branch
6 times, most recently
from
April 3, 2026 10:06
2105ded to
6874ede
Compare
napoly
force-pushed
the
simulate-subaddress-duplicate-key-violation
branch
from
April 3, 2026 11:24
6874ede to
d35783c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simulates the
duplicate key value violates unique constraint "PK_AddressInvoices"from #57High level steps:
EnableMoneroPluginSuccessfullycreates a view wallet and generates an invoice (subaddress)EnableMoneroPluginSuccessfullySecondruns creating the same view wallet and tries to generate an invoice but it fails as this subaddress violates the unique constrain on db https://github.com/btcpay-monero/btcpayserver-monero-plugin/actions/runs/19635416708/job/56224799919?pr=61#step:9:2238Wanted behavior:
A unique subaddress should be generated under all circumstances.