Skip to content

fix(tron): exclude-amount mode emits a bare address so all wallet QR scanners can parse it #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
curtisgray wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(tron): exclude-amount mode emits a bare address so all wallet QR scanners can parse it #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BTCPayServer.Plugins.USDt.Tests/FastTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void TronPaymentLinkIncludesAmountByDefault()
12.34m,
false);

Assert.Equal("TG3XXyExBkPp9nzdajDZsozEu4BkaSJozs?amount=12.34", result);
Assert.Equal("tron:TG3XXyExBkPp9nzdajDZsozEu4BkaSJozs?amount=12.34", result);
}

[Fact]
Expand Down
5 changes: 4 additions & 1 deletion BTCPayServer.Plugins.USDt/Services/Payments/TronUSDtPaymentLinkExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ public class TronUSDtPaymentLinkExtension(PaymentMethodId paymentMethodId) : IPa
if (string.IsNullOrEmpty(destination))
return null;

// Bare address, no URI scheme: the store setting documents this mode as "the QR
// code will only contain the destination address", and QR scanners that reject
// tron: URIs (e.g. TronLink's in-Send scanner) only accept a plain base58 address.
if (excludeAmount)
return $"tron:{destination}";
return destination;

return $"tron:{destination}?amount={due.ToString(CultureInfo.InvariantCulture)}";
}
Expand Down