Fix existing Bitcoin node Docker example to require NBXplorer - #1607
Open
steven-s-martins wants to merge 1 commit into
Open
Fix existing Bitcoin node Docker example to require NBXplorer#1607steven-s-martins wants to merge 1 commit into
steven-s-martins wants to merge 1 commit into
Conversation
Preserve the nbxplorer fragment dependency when excluding bitcoin, and append to BTCPAYGEN_EXCLUDE_FRAGMENTS instead of overwriting it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required: - "nbxplorer"dependency to thebitcoin.custom.ymlexample used when deploying BTCPay alongside an existing Bitcoin node. Excluding the standardbitcoinfragment also drops that dependency, so without it NBXplorer is omitted from the generated Compose config.BTCPAYGEN_EXCLUDE_FRAGMENTSinstead of overwriting it, matching the existingBTCPAYGEN_ADDITIONAL_FRAGMENTSpattern so prior excludes are preserved.Test plan
required: - "nbxplorer"nbxplorerappears indocker compose -f docker-compose.generated.yml config --servicesBTCPAYGEN_EXCLUDE_FRAGMENTSvalue is preserved after running the documented exportMade with Cursor