Skip to content

added _maintainer field in json files - #58

Closed
ABC-8888 wants to merge 2 commits into
btcpayserver:mainfrom
ABC-8888:adding-maintainer-property
Closed

added _maintainer field in json files#58
ABC-8888 wants to merge 2 commits into
btcpayserver:mainfrom
ABC-8888:adding-maintainer-property

Conversation

@ABC-8888

@ABC-8888 ABC-8888 commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Adding placeholder "_maintainer" field in json files for translations.

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request adds a _maintainer metadata field to each of eleven translation JSON files. The addition is uniform across all files, with a single line inserted at line 2 in each translation document without modifying any translation content.

Changes

Translation Maintainer Metadata

Layer / File(s) Summary
Maintainer Metadata
translations/dutch.json, translations/hindi.json, translations/indonesian.json, translations/italian.json, translations/japanese.json, translations/korean.json, translations/norwegian.json, translations/romanian.json, translations/russian.json, translations/thai.json, translations/turkish.json
Each translation file receives a new top-level _maintainer field to identify and track the translation maintainer.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Eleven tongues now bear a keeper's name,
A _maintainer field marks their claim.
From Dutch to Turkish, each file grows,
A simple addition that everyone knows! 🌍✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a pull request description explaining the purpose of adding the _maintainer field and how it benefits the translation workflow.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'added _maintainer field in json files' directly and clearly summarizes the main change across all modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 11

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@translations/dutch.json`:
- Line 2: Replace the placeholder value for the "_maintainer" key in
translations/dutch.json with real maintainer metadata: provide the maintainer's
full name and a valid contact or profile link (e.g., GitHub URL) in a clear
format (e.g., "Full Name | https://github.com/username") so the field is
actionable and free of typos.

In `@translations/hindi.json`:
- Line 2: Update the _maintainer metadata entry so it contains real maintainer
information instead of the placeholder and fix the typo; locate the
"_maintainer" JSON key and replace "your_name|yout_git_hub_link" with a valid
maintainer name and a correct GitHub URL or contact (e.g., "Full Name |
https://github.com/yourhandle") ensuring proper JSON string formatting and no
typos.

In `@translations/indonesian.json`:
- Line 2: The "_maintainer" placeholder value contains a typo; update the string
value for the "_maintainer" key from "your_name|yout_git_hub_link" to
"your_name|your_github_link" so the placeholder correctly references
"your_github_link" (locate the "_maintainer" key in translations/indonesian.json
and replace the misspelled segment).

In `@translations/italian.json`:
- Line 2: The _maintainer value in translations/italian.json is a placeholder
with a typo; replace the string value for the "_maintainer" key with the actual
maintainer name and a valid GitHub profile URL (e.g., "Full
Name|https://github.com/username"), correcting "yout" to "your" as needed so the
metadata is actionable.

In `@translations/japanese.json`:
- Line 2: Fix the typo in the translation placeholder for the "_maintainer" key:
change the value "your_name|yout_git_hub_link" to "your_name|your_github_link".
Update the same placeholder consistently across all related translation files
that use the "_maintainer" key in this PR.

In `@translations/korean.json`:
- Line 2: Replace the placeholder value for the JSON key "_maintainer" with the
real maintainer's name and their GitHub profile URL (fix the typo
"yout_git_hub_link"), e.g. "Full Name | https://github.com/username"; ensure the
string is updated exactly for the "_maintainer" key and preserves JSON
quoting/formatting.

In `@translations/norwegian.json`:
- Line 2: Replace the placeholder value for the "_maintainer" key with the real
maintainer name and a correct GitHub profile URL (fixing the "yout_git_hub_link"
typo), e.g. set "_maintainer" to "Full Name|https://github.com/username" so the
metadata is actionable and accurate; update the "_maintainer" entry in
translations/norwegian.json accordingly.

In `@translations/romanian.json`:
- Line 2: Replace the placeholder maintainer metadata for the translation by
updating the "_maintainer" value (the JSON key "_maintainer") in
translations/romanian.json to the real maintainer's name and GitHub URL (e.g.
"Full Name|https://github.com/username"); ensure the string uses the same JSON
formatting and is a valid URL separated by a pipe as the project expects.

In `@translations/russian.json`:
- Line 2: Replace the placeholder value for the "_maintainer" key in
translations/russian.json with the real maintainer metadata (e.g., "Full
Name|https://github.com/username") and correct the typo in the template if you
keep a templated format (change "yout_git_hub_link" to "your_github_link" or
include the actual GitHub URL); ensure the string follows the project convention
"Name|GitHubURL" and update the value for the "_maintainer" key accordingly.

In `@translations/thai.json`:
- Line 2: The "_maintainer" placeholder value contains a typo; update the string
value for the "_maintainer" key from "yout_git_hub_link" to "your_github_link"
so the placeholder correctly reads "your_name|your_github_link" (locate the
"_maintainer" entry in translations/thai.json and correct the value).

In `@translations/turkish.json`:
- Line 2: Fix the typo in the translation key "_maintainer": change the
placeholder value from "yout_git_hub_link" to "your_github_link" and optionally
replace the whole placeholder with the real maintainer name and GitHub profile
(e.g., "Your Name|https://github.com/yourusername") so the "_maintainer" entry
contains correct and useful info.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1762b80d-ddd4-43fc-b97d-ac5e9dac1692

📥 Commits

Reviewing files that changed from the base of the PR and between 3fdd343 and 588e135.

📒 Files selected for processing (11)
  • translations/dutch.json
  • translations/hindi.json
  • translations/indonesian.json
  • translations/italian.json
  • translations/japanese.json
  • translations/korean.json
  • translations/norwegian.json
  • translations/romanian.json
  • translations/russian.json
  • translations/thai.json
  • translations/turkish.json

Comment thread translations/dutch.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace placeholder _maintainer value with real maintainer metadata.

Line 2 currently uses a template/typo value (your_name|yout_git_hub_link) instead of real maintainer info, so the new field is not actionable.

Suggested fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "Sanja22B|https://github.com/Sanja22B",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "Sanja22B|https://github.com/Sanja22B",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/dutch.json` at line 2, Replace the placeholder value for the
"_maintainer" key in translations/dutch.json with real maintainer metadata:
provide the maintainer's full name and a valid contact or profile link (e.g.,
GitHub URL) in a clear format (e.g., "Full Name | https://github.com/username")
so the field is actionable and free of typos.

Comment thread translations/hindi.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace placeholder _maintainer value with real maintainer metadata.

Line 2 still uses a template value and has a typo (yout_git_hub_link), so this metadata won’t be useful for ownership tracking.

Suggested fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "Your Name|https://github.com/your-github-handle",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "Your Name|https://github.com/your-github-handle",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/hindi.json` at line 2, Update the _maintainer metadata entry so
it contains real maintainer information instead of the placeholder and fix the
typo; locate the "_maintainer" JSON key and replace
"your_name|yout_git_hub_link" with a valid maintainer name and a correct GitHub
URL or contact (e.g., "Full Name | https://github.com/yourhandle") ensuring
proper JSON string formatting and no typos.

Comment thread translations/indonesian.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typo in placeholder text.

The placeholder contains a typo: yout_git_hub_link should be your_github_link.

📝 Proposed fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "your_name|your_github_link",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "your_name|your_github_link",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/indonesian.json` at line 2, The "_maintainer" placeholder value
contains a typo; update the string value for the "_maintainer" key from
"your_name|yout_git_hub_link" to "your_name|your_github_link" so the placeholder
correctly references "your_github_link" (locate the "_maintainer" key in
translations/indonesian.json and replace the misspelled segment).

Comment thread translations/italian.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace placeholder _maintainer value with real maintainer metadata

Line 2 still uses a template value (your_name|yout_git_hub_link) and includes a typo (yout). Please replace it with the actual maintainer name and GitHub profile link so this metadata is actionable.

✅ Suggested fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "Sanja22B|https://github.com/Sanja22B",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "Sanja22B|https://github.com/Sanja22B",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/italian.json` at line 2, The _maintainer value in
translations/italian.json is a placeholder with a typo; replace the string value
for the "_maintainer" key with the actual maintainer name and a valid GitHub
profile URL (e.g., "Full Name|https://github.com/username"), correcting "yout"
to "your" as needed so the metadata is actionable.

Comment thread translations/japanese.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix typo in the placeholder value.

The placeholder text contains a typo: yout_git_hub_link should be your_github_link for clarity.

✏️ Proposed fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "your_name|your_github_link",

Note: This typo likely appears in all 11 translation files mentioned in the PR summary and should be corrected consistently across all files.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "your_name|your_github_link",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/japanese.json` at line 2, Fix the typo in the translation
placeholder for the "_maintainer" key: change the value
"your_name|yout_git_hub_link" to "your_name|your_github_link". Update the same
placeholder consistently across all related translation files that use the
"_maintainer" key in this PR.

Comment thread translations/norwegian.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Replace placeholder maintainer metadata with real maintainer info.

Line 2 currently uses a placeholder ("your_name|yout_git_hub_link"), so the new metadata is not actionable and includes a typo. Please set a real maintainer name and GitHub profile link before merge.

Suggested fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "<maintainer_name>|https://github.com/<maintainer_handle>",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "<maintainer_name>|https://github.com/<maintainer_handle>",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/norwegian.json` at line 2, Replace the placeholder value for the
"_maintainer" key with the real maintainer name and a correct GitHub profile URL
(fixing the "yout_git_hub_link" typo), e.g. set "_maintainer" to "Full
Name|https://github.com/username" so the metadata is actionable and accurate;
update the "_maintainer" entry in translations/norwegian.json accordingly.

Comment thread translations/romanian.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use actual maintainer metadata instead of the placeholder value.

Line 2 still has "your_name|yout_git_hub_link", which looks like template text rather than real ownership metadata. Please replace it with the real maintainer name and GitHub URL.

Suggested fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "<maintainer_name>|https://github.com/<maintainer_handle>",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "<maintainer_name>|https://github.com/<maintainer_handle>",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/romanian.json` at line 2, Replace the placeholder maintainer
metadata for the translation by updating the "_maintainer" value (the JSON key
"_maintainer") in translations/romanian.json to the real maintainer's name and
GitHub URL (e.g. "Full Name|https://github.com/username"); ensure the string
uses the same JSON formatting and is a valid URL separated by a pipe as the
project expects.

Comment thread translations/russian.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Replace placeholder _maintainer with real maintainer metadata

Line 2 currently uses a template value (your_name|yout_git_hub_link) and contains a typo in the placeholder. Please set an actual maintainer identifier (and correct the placeholder text format if templates are intentional).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/russian.json` at line 2, Replace the placeholder value for the
"_maintainer" key in translations/russian.json with the real maintainer metadata
(e.g., "Full Name|https://github.com/username") and correct the typo in the
template if you keep a templated format (change "yout_git_hub_link" to
"your_github_link" or include the actual GitHub URL); ensure the string follows
the project convention "Name|GitHubURL" and update the value for the
"_maintainer" key accordingly.

Comment thread translations/thai.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Typo in placeholder text: "yout_git_hub_link" should be "your_github_link"

The maintainer field placeholder contains a typo: "yout_git_hub_link" is missing the 'r' in "your". This should be corrected to "your_github_link" for clarity.

📝 Proposed fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "your_name|your_github_link",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "your_name|your_github_link",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/thai.json` at line 2, The "_maintainer" placeholder value
contains a typo; update the string value for the "_maintainer" key from
"yout_git_hub_link" to "your_github_link" so the placeholder correctly reads
"your_name|your_github_link" (locate the "_maintainer" entry in
translations/thai.json and correct the value).

Comment thread translations/turkish.json Outdated
@@ -1,4 +1,5 @@
{
"_maintainer": "your_name|yout_git_hub_link",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the typo in the placeholder text.

There's a spelling error in the maintainer field placeholder: "yout_git_hub_link" should be "your_github_link".

Additionally, consider replacing the placeholder text with actual maintainer information (name and GitHub profile link) for this translation file.

🔧 Suggested fix
-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "your_name|your_github_link",

Or better yet, fill in the actual maintainer details:

-  "_maintainer": "your_name|yout_git_hub_link",
+  "_maintainer": "Maintainer Name|https://github.com/username",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"_maintainer": "your_name|yout_git_hub_link",
"_maintainer": "your_name|your_github_link",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@translations/turkish.json` at line 2, Fix the typo in the translation key
"_maintainer": change the placeholder value from "yout_git_hub_link" to
"your_github_link" and optionally replace the whole placeholder with the real
maintainer name and GitHub profile (e.g., "Your
Name|https://github.com/yourusername") so the "_maintainer" entry contains
correct and useful info.

@ABC-8888 ABC-8888 changed the title added _maintainer field in json file added _maintainer field in json files May 8, 2026
@ABC-8888 ABC-8888 closed this May 8, 2026
@ABC-8888
ABC-8888 deleted the adding-maintainer-property branch May 8, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant