Add isolated macro storage and dedicated macro management#362
Open
Q1WP wants to merge 11 commits intobuildbotics:masterfrom
Open
Add isolated macro storage and dedicated macro management#362Q1WP wants to merge 11 commits intobuildbotics:masterfrom
Q1WP wants to merge 11 commits intobuildbotics:masterfrom
Conversation
Member
|
Sorry, it's taking me awhile to get time to look at these in detail. I've seen they exist and will look at them as soon as I get a chance. I'm traveling a lot right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test deployment: http://bbctrl.dyndns.org:8091/
Fixes #346.
Fixes #347.
This PR contains the macro-related changes requested after the earlier mixed
PRs.
Changes:
Home/macrosstorage on save/load migration. Older configs are migrated automatically, and
orphaned protected macro files are cleaned up.
are referenced automatically, and manually set positions also establish
reference.
skip_reference_check: per-macro override for homing/setup macros that mustrun before axes are referenced.
restored.
Macrospage: moves macro management out ofSettings -> Macrosinto adedicated top-level page.
control page, and optionally confirmed before run.
ZEROEDstate: referenced-but-not-homed axes are shown separately from fullyunreferenced axes.
file browser, but active macro files remain readable so the control page,
editor, and toolpath viewer still work.
confirm dialog, which avoids confirm-then-fail behavior.
Implementation notes:
not renamed or modified
APIs
page, editor, and toolpath viewer work while a macro is running
Validation:
python3 -m py_compileon changed Python filesnode -con changed JS filesvisibility, confirm on/off,
skip_reference_check, active macro display, andlogged-out/read-only macro editing