sim_irq: guard NULL pool in avr_irq_register_notify during reset - #584
Open
dmcgougan wants to merge 1 commit into
Open
sim_irq: guard NULL pool in avr_irq_register_notify during reset#584dmcgougan wants to merge 1 commit into
dmcgougan wants to merge 1 commit into
Conversation
Interrupt-vector IRQs are created with pool == NULL. avr_watchdog_reset() re-registers its notify hook from within avr_reset (while avr->resetting is set), so avr_irq_register_notify() dereferences irq->pool->avr->resetting on an IRQ whose pool is NULL and segfaults on any watchdog reset. Guard the NULL pool so the reset path is safe; the resetting-time value/flag reset simply does not apply to pool-less IRQs.
Collaborator
|
Please post code and instructions to reproduce the crash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupt-vector IRQs are created with pool == NULL. avr_watchdog_reset() re-registers its notify hook from within avr_reset (while avr->resetting is set), so avr_irq_register_notify() dereferences irq->pool->avr->resetting on an IRQ whose pool is NULL and segfaults on any watchdog reset.
Guard the NULL pool so the reset path is safe; the resetting-time value/flag reset simply does not apply to pool-less IRQs.